-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Snowflake SELECT *
wildcard REPLACE ... RENAME
order
#1321
Merged
alamb
merged 1 commit into
apache:main
from
alexander-beedie:wildcard-replace-rename-order
Jun 27, 2024
Merged
Fix Snowflake SELECT *
wildcard REPLACE ... RENAME
order
#1321
alamb
merged 1 commit into
apache:main
from
alexander-beedie:wildcard-replace-rename-order
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
force-pushed
the
wildcard-replace-rename-order
branch
from
June 23, 2024 19:24
7ef2d21
to
e4ceed7
Compare
Pull Request Test Coverage Report for Build 9635875595Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9635889639Details
💛 - Coveralls |
iffyio
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
alexander-beedie
changed the title
Fix Snowflake wildcard
Fix Snowflake Jun 26, 2024
REPLACE ... RENAME
orderSELECT *
wildcard REPLACE ... RENAME
order
alamb
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alexander-beedie and @iffyio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects parsing of Snowflake
SELECT * <opts>
wildcard options that contain bothRENAME
andREPLACE
options.As per the Snowflake docs1:
Made a minor fix and added a unit test to validate it and provide the missing coverage.
Footnotes
https://docs.snowflake.com/en/sql-reference/sql/select#parameters ↩