Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Spark-compatible CAST from floating-point to decimal #371

Closed
andygrove opened this issue May 2, 2024 · 1 comment · Fixed by #384
Closed

Implement Spark-compatible CAST from floating-point to decimal #371

andygrove opened this issue May 2, 2024 · 1 comment · Fixed by #384
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

Comet's implementation of CAST float/double to Decimal delegates to DataFusion and is not compatible with Spark.

The following test in CometCastSuite can be used to see the current failures.

  ignore("cast DoubleType to DecimalType(10,2)") {
    // Comet should have failed with [NUMERIC_VALUE_OUT_OF_RANGE]
    castTest(generateDoubles(), DataTypes.createDecimalType(10, 2))
  }

Describe the potential solution

No response

Additional context

No response

@andygrove andygrove added the enhancement New feature or request label May 2, 2024
@vaibhawvipul
Copy link
Contributor

I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants