Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all tests in CometTPCHQuerySuite #258

Closed
viirya opened this issue Apr 11, 2024 · 0 comments · Fixed by #257
Closed

Enable all tests in CometTPCHQuerySuite #258

viirya opened this issue Apr 11, 2024 · 0 comments · Fixed by #257
Labels
enhancement New feature or request

Comments

@viirya
Copy link
Member

viirya commented Apr 11, 2024

What is the problem the feature request solves?

We disabled 4 tests ("q1", "q15", "q17", "q18") in CometTPCHQuerySuite before because Comet produces different results than Spark. We should re-enable them after Comet can produce correct results.

Describe the potential solution

No response

Additional context

No response
@viirya viirya added the enhancement New feature or request label Apr 11, 2024
@viirya viirya mentioned this issue Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Enable all remaining TPCH queries viirya/arrow-datafusion-comet
1 participant
@viirya