Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Hash Expressions support #205

Closed
3 of 7 tasks
advancedxy opened this issue Mar 13, 2024 · 1 comment · Fixed by #226
Closed
3 of 7 tasks

[Epic] Hash Expressions support #205

advancedxy opened this issue Mar 13, 2024 · 1 comment · Fixed by #226
Labels
enhancement New feature or request

Comments

@advancedxy
Copy link
Contributor

advancedxy commented Mar 13, 2024

What is the problem the feature request solves?

When implementing BloomFilterMightContain, I noticed the second parameter is usually came from a hash function, such as xxhash64. Comet only support murmur3_hash in the Rust side. We should also support other hash function in Comet.

Describe the potential solution

Add various hash expression support, such as:


  • Md5
  • Sha1
  • Sha2
  • Crc32

This functions may has lower priority

Additional context

No response

@advancedxy advancedxy added the enhancement New feature or request label Mar 13, 2024
@advancedxy
Copy link
Contributor Author

Hmm, I checked datafusion side, looks like md5 and shas are already implemented in the Datafusion side.

FYI, I am going to work on murmur3, md5 and sha supports, and then xxhash64 support this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant