[CB-11462] Fixes the Coordinate speed and heading attribute to follow the w3c specification on all platforms #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlegenhausen
changed the title
added 2 commits
June 21, 2016 10:31
…tion. Speed can have a negative value on iOS devices when the OS is not able to determine the current speed. This is against the w3c specification. Which only allows null and a number value >= 0. See the following links for further informations: * https://dev.w3.org/geo/api/spec-source.html#speed * https://developer.apple.com/library/ios/documentation/CoreLocation/Reference/CLLocation_Class/#//apple_ref/occ/instp/CLLocation/speed
…cation. Heading (course) can have a negative value on iOS devices when the OS is not able to determine the current heading. This is against the w3c specification. Which only allows null and a number value >= 0 and <= 360. See the following links for further informations: * https://dev.w3.org/geo/api/spec-source.html#heading * https://developer.apple.com/library/ios/documentation/CoreLocation/Reference/CLLocation_Class/#//apple_ref/occ/instp/CLLocation/course
|
superceded by #270 which is a rebased version of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS returns negative values for heading/course and speed when the values can not be determined. These values are exposed by the current API which leads to unwanted behavior of the API. This pull request adds extra checks to the
Coordinatesobject and makes surespeedandheadingcan only have values defined in the W3C Geolocation API Specification.See also:
Platforms affected
Primary iOS. Fixes all invalid values provided by other platforms.
What does this PR do?
Makes sure the resulting Coordinates object follows the W3C specification.
What testing has been done on this change?
Tested on iOS.
Checklist