fix: heading speed w3c spec #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2023 22:37
…tion. Speed can have a negative value on iOS devices when the OS is not able to determine the current speed. This is against the w3c specification. Which only allows null and a number value >= 0. See the following links for further informations: * https://dev.w3.org/geo/api/spec-source.html#speed * https://developer.apple.com/library/ios/documentation/CoreLocation/Reference/CLLocation_Class/#//apple_ref/occ/instp/CLLocation/speed
…cation. Heading (course) can have a negative value on iOS devices when the OS is not able to determine the current heading. This is against the w3c specification. Which only allows null and a number value >= 0 and <= 360. See the following links for further informations: * https://dev.w3.org/geo/api/spec-source.html#heading * https://developer.apple.com/library/ios/documentation/CoreLocation/Reference/CLLocation_Class/#//apple_ref/occ/instp/CLLocation/course
erisu
approved these changes
Sep 15, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
ALl
Motivation and Context
Rebase of #77
Maintains the W3C spec by initializing
speedandheadingtonullif the values are not found or not within the expected range. See https://w3c.github.io/geolocation-api/#constructing-a-geolocationposition for more details:Description
Asserts the values are in proper range
Testing
npm testNote that test fails without manual interactions on the simulator due to the permission prompts.
Checklist
(platform)if this change only applies to one platform (e.g.(android))