CB-11771 Deep symlink directories to target project instead of linking the directory itself #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the directory itself When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in 2 projects targeting different Cordova versions.
Current coverage is 33.67% (diff: 20.00%)@@ master #326 diff @@
==========================================
Files 11 11
Lines 965 968 +3
Methods 197 199 +2
Messages 0 0
Branches 157 158 +1
==========================================
Hits 326 326
- Misses 639 642 +3
Partials 0 0
|
|
Can someone please review this PR? apache/cordova-ios#244 is already merged and in order to fix the issue we need this one and apache/cordova-lib#485 as well. |
|
I confirmed the leaking and your patch solves the problem. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing a plugin with custom library using the --link option the whole directory is symlinked and temporary
files leak into the original plugin directory on build. This leads to broken builds if the same plugin is linked in
2 projects targeting different Cordova versions.
fixes CB-11771 Installing plugin with symlink option pollutes original directory with intermediate files