From 536587931cb77538709c57455165379a74e2f04f Mon Sep 17 00:00:00 2001 From: Alex Herbert Date: Thu, 27 Aug 2020 23:10:27 +0100 Subject: [PATCH] Test the codec policy property --- src/test/java/org/apache/commons/codec/binary/Base16Test.java | 2 ++ src/test/java/org/apache/commons/codec/binary/Base32Test.java | 2 ++ src/test/java/org/apache/commons/codec/binary/Base64Test.java | 2 ++ 3 files changed, 6 insertions(+) diff --git a/src/test/java/org/apache/commons/codec/binary/Base16Test.java b/src/test/java/org/apache/commons/codec/binary/Base16Test.java index c9a6332255..fc7249f82f 100644 --- a/src/test/java/org/apache/commons/codec/binary/Base16Test.java +++ b/src/test/java/org/apache/commons/codec/binary/Base16Test.java @@ -587,6 +587,7 @@ public void testStrictDecoding() { final String encoded = "aabbccdde"; // Note the trailing `e` which does not make up a hex-pair and so is only 1/2 byte final Base16 b16 = new Base16(true, CodecPolicy.STRICT); + assertEquals(CodecPolicy.STRICT, b16.getCodecPolicy()); b16.decode(StringUtils.getBytesUtf8(encoded)); } @@ -595,6 +596,7 @@ public void testLenientDecoding() { final String encoded = "aabbccdde"; // Note the trailing `e` which does not make up a hex-pair and so is only 1/2 byte final Base16 b16 = new Base16(true, CodecPolicy.LENIENT); + assertEquals(CodecPolicy.LENIENT, b16.getCodecPolicy()); final byte[] decoded = b16.decode(StringUtils.getBytesUtf8(encoded)); assertArrayEquals(new byte[] {(byte)0xaa, (byte)0xbb, (byte)0xcc, (byte)0xdd}, decoded); diff --git a/src/test/java/org/apache/commons/codec/binary/Base32Test.java b/src/test/java/org/apache/commons/codec/binary/Base32Test.java index 83f1c2f604..ddc286a1ab 100644 --- a/src/test/java/org/apache/commons/codec/binary/Base32Test.java +++ b/src/test/java/org/apache/commons/codec/binary/Base32Test.java @@ -367,9 +367,11 @@ private static void assertBase32DecodingOfTrailingBits(final int nbits) { // Requires strict decoding final Base32 codec = new Base32(0, null, false, BaseNCodec.PAD_DEFAULT, CodecPolicy.STRICT); assertTrue(codec.isStrictDecoding()); + assertEquals(CodecPolicy.STRICT, codec.getCodecPolicy()); // A lenient decoder should not re-encode to the same bytes final Base32 defaultCodec = new Base32(); assertFalse(defaultCodec.isStrictDecoding()); + assertEquals(CodecPolicy.LENIENT, defaultCodec.getCodecPolicy()); // Create the encoded bytes. The first characters must be valid so fill with 'zero' // then pad to the block size. diff --git a/src/test/java/org/apache/commons/codec/binary/Base64Test.java b/src/test/java/org/apache/commons/codec/binary/Base64Test.java index caf5363856..82671ff603 100644 --- a/src/test/java/org/apache/commons/codec/binary/Base64Test.java +++ b/src/test/java/org/apache/commons/codec/binary/Base64Test.java @@ -1363,9 +1363,11 @@ private static void assertBase64DecodingOfTrailingBits(final int nbits) { final Base64 codec = new Base64(0, null, false, CodecPolicy.STRICT); // Requires strict decoding assertTrue(codec.isStrictDecoding()); + assertEquals(CodecPolicy.STRICT, codec.getCodecPolicy()); // A lenient decoder should not re-encode to the same bytes final Base64 defaultCodec = new Base64(); assertFalse(defaultCodec.isStrictDecoding()); + assertEquals(CodecPolicy.LENIENT, defaultCodec.getCodecPolicy()); // Create the encoded bytes. The first characters must be valid so fill with 'zero' // then pad to the block size.