-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KnativeService URL is based on the Integration name rather than the consumer endpoint name #2249
Comments
This issue has been automatically marked as stale due to 90 days of inactivity. |
I will take a look at this |
I am not sure if Also, I think the endpoint name used in the Camel route represents something different. I would expect that the endpoint defines the resource subpath of the service so that This would also play nice with multiple endpoints being set via the Camel routes, because requests get routed to the different endpoints via request paths. We should add more testing to that first in order to see how this really behaves. |
As Christoph mentioned knative service URL is derived from integration name. This allows more intuitive naming if more endpoints are present in an integration. |
Currently, when deploying an Integration with a Knative Service endpoint, the created service URL depends on the Integration name, rather than the endpoint name. For example, when running
kamel run -n test
with:The Knative Service is accessible from
http://test.ns.domain
.This causes confusion, as users may assume the service information is based on the endpoint information. The documentation also states that the
name
path parameter identifies the Knative resource:https://github.com/apache/camel-k-runtime/blob/4f356e03bccbea2cb6a226aece6bce27ca1af9b8/components/camel-knative/camel-knative/src/main/docs/knative-component.adoc#path-parameters-2-parameters
Either it's possible to have the KnativeService URL based on the endpoint name, or we may better remove the path from our examples, as it has no meaning. This also raises the question of the support for multiple Knative consumer endpoints. Any conventions or limitations should be documented.
/cc @mmelko
The text was updated successfully, but these errors were encountered: