Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong FlvWriter header when audo/video only #1110

Closed
zyearn opened this issue May 9, 2020 · 6 comments · Fixed by #1505
Closed

Wrong FlvWriter header when audo/video only #1110

zyearn opened this issue May 9, 2020 · 6 comments · Fixed by #1505
Labels
good first issue Good for newcomers

Comments

@zyearn
Copy link
Member

zyearn commented May 9, 2020

Describe the bug (描述bug)

FlvWriter直接在header中的媒体标识位中写入0x05(0x04是音频,0x01是视频),忽略了用户可能只需要音频/视频,导致flv的音频/视频流在某些播放器中无法播放。

To Reproduce (复现方法)

Expected behavior (期望行为)

根据用户输入来写入header。

@zyearn zyearn self-assigned this May 9, 2020
@zyearn zyearn removed their assignment Aug 19, 2020
@zyearn zyearn added the good first issue Good for newcomers label Aug 19, 2020
@luluyouyue
Copy link

老大,这个问题解决了吗

@zyearn
Copy link
Member Author

zyearn commented Sep 30, 2020

还没有,有兴趣的话可以给我们提pr。

@luluyouyue
Copy link

还没有,有兴趣的话可以给我们提pr。

我试试^_^

@luluyouyue
Copy link

我看了下代码,不是很懂这个问题的解决思路,什么叫根据用户输入来写入header?

@zyearn
Copy link
Member Author

zyearn commented Oct 1, 2020

比如可以给flvWriter的构造函数加一个struct FlvWriterOption类似的参数,里面用来控制用户的预期行为。

@v1siuol
Copy link
Contributor

v1siuol commented Jul 31, 2021

I can pick up this one, if still available :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants