Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Re-use BatchConverterTest for different implementations #22950

Open
TheNeuralBit opened this issue Aug 29, 2022 · 0 comments
Open

[Task]: Re-use BatchConverterTest for different implementations #22950

TheNeuralBit opened this issue Aug 29, 2022 · 0 comments

Comments

@TheNeuralBit
Copy link
Member

What needs to happen?

We have BatchConverterTest in batch.py, which is used to test the list and numpy implementations. As more BatchConverter implementations are added they will need to add tests that are almost identical to this one, with a few alterations:

  • The test data, currently handled with parameterized_class.
  • Possibly a custom equality check (e.g. pd.testing.assert_frame_equal for pandas)

We should make it possible to re-use the tests in BatchConverterTest without copy-pasting it, as this will lead to fragmentation.

Issue Priority

Priority: 2

Issue Component

Component: dsl-dataframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants