Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45005 [C++] Support for fixed-size list in conversion of range tuple #45008

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

mroz45
Copy link
Contributor

@mroz45 mroz45 commented Dec 12, 2024

What changes are included in this PR?

This PR introduces support for fixed-size lists in Apache Arrow's STL conversion. Added specializations for arrow::stl::ConversionTraits and arrow::CTypeTraits to handle std::array as a fixed-size list and also Unit Test.

Are these changes tested?

Yes, new type is tested.

Are there any user-facing changes?

Copy link

⚠️ GitHub issue #45005 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @mroz45 . I think this is a good idea, can please address the following comments?

cpp/src/arrow/stl_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/stl_test.cc Show resolved Hide resolved
cpp/src/arrow/stl_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/stl_test.cc Show resolved Hide resolved
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 12, 2024
@mroz45
Copy link
Contributor Author

mroz45 commented Dec 12, 2024

Thanks for doing this @mroz45 . I think this is a good idea, can please address the following comments?

Is it looking good for now? @pitrou

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit of naming.

cpp/src/arrow/stl.h Outdated Show resolved Hide resolved
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now @mroz45 , please just address @zanmato1984 's comment.

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the lint (format) issue in CI. Then I'll merge it. Thanks.

@zanmato1984
Copy link
Contributor

LGTM. Please fix the lint (format) issue in CI. Then I'll merge it. Thanks.

Never mind the format, I've rebased the PR and fixed the format issue. Let's wait for CI.

@zanmato1984 zanmato1984 merged commit 37eb3b5 into apache:main Dec 18, 2024
36 of 37 checks passed
@zanmato1984 zanmato1984 removed the awaiting committer review Awaiting committer review label Dec 18, 2024
@zanmato1984
Copy link
Contributor

zanmato1984 commented Dec 18, 2024

The CI failure is unrelated. Merging. Thank you @mroz45 for this!

Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 37eb3b5.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants