Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Remove usage of deprecated pkg_resources in setup.py #43532

Closed
jorisvandenbossche opened this issue Aug 2, 2024 · 3 comments · Fixed by #43602
Closed

[Python] Remove usage of deprecated pkg_resources in setup.py #43532

jorisvandenbossche opened this issue Aug 2, 2024 · 3 comments · Fixed by #43602

Comments

@jorisvandenbossche
Copy link
Member

See https://setuptools.pypa.io/en/latest/pkg_resources.html

We currently use this to get the numpy include directories:

numpy_incl = pkg_resources.resource_filename('numpy', 'core/include')

The general deprecation of pkg_resources points to use importlib instead (https://docs.python.org/3.11/library/importlib.resources.html#module-importlib.resources), but for this specific usage I think we just should use numpy.get_include() (https://numpy.org/devdocs/reference/generated/numpy.get_include.html)

@pitrou
Copy link
Member

pitrou commented Aug 8, 2024

Issue resolved by pull request 43602
#43602

@pitrou
Copy link
Member

pitrou commented Aug 8, 2024

@tlm365 Can you post a comment here? This will allow assigning the issue to you.

@tlm365
Copy link
Contributor

tlm365 commented Aug 8, 2024

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants