-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-43390: [C++] Add support for building on Android porting patch from vcpkg #43407
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try adding a new nightly CI job for Android?
Related documentations:
- https://developer.android.com/ndk/guides/cmake
- https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-android
Android NDK download: https://developer.android.com/ndk/downloads
GitHub Actions runner has Android NDK by default: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
#ifndef _WIN32 | ||
# if !(defined(__ANDROID__) && __ANDROID_API__ < 26) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we unify this condition?
#if !defined(_WIN32) && !(defined(__ANDROID__) && __ANDROID_API__ < 26)
BTW, is Android API < 26 still supported?
It seems that Android API 25 is Android 7.1 based on https://developer.android.com/guide/topics/manifest/uses-sdk-element#api-level-table .
It seems that Android 11 or earlier reached EOL based on https://endoflife.date/android .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a good point, we can remove this patch and probably remove it also upstream on the next release. It shouldn't be necessary as unsupported version, I suppose if we add an Android CI job might be worth validating
That's a good point, I currently have other priorities. I want to update vcpkg, start preparing for Python 3.13 and update the MACOS_DEPLOYMENT_TARGET as we are seeing several failures related. I'll add the Android CI to the bottom of this list :) |
Rationale for this change
We had to apply a patch on vcpkg in order to build on Android. Adding this patch to the main arrow repo to remove upstream patch.
The upstream patch: https://github.com/microsoft/vcpkg/blob/43586b1aa054ba3e453c5cce2c13cae64b61e5e1/ports/arrow/android.patch
What changes are included in this PR?
Some minor changes to allow build on Android
Are these changes tested?
On CI, build for Android must be tested upstream but the patch has been tested on vcpkg.
Are there any user-facing changes?
No