Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Explicitly enumerate the ParquetReaderProperties and ParquetArrowReaderProperties arguments in write_parquet() #36997

Open
thisisnic opened this issue Aug 2, 2023 · 0 comments

Comments

@thisisnic
Copy link
Member

Describe the enhancement requested

Expand the read_parquet() function signature to explicitly enumerate each of the arguments for ParquetReaderProperties$create() and ParquetArrowReaderProperties$create() - see how this is done in write_parquet() for each of the arguments in `ParquetWriterProperties$create as an example.

Arguments to add:

  • enable_buffered_stream - default value FALSE
  • buffer_size - default value 4096 * 4
  • thrift_string_size_limit - default value 100 * 1000 * 1000
  • thrift_container_size_limit - default value 1000 * 1000
  • file_decryption_properties
  • page_checksum_verification - default value FALSE
  • use_threads - default value option_use_threads()
  • pre_buffer - default value FALSE

Arguments to deprecate:

  • props - deprecate this for now via a warning generated by the lifecycle package

This doesn't need to be done in 1 PR.

New arguments should also be tested

Component(s)

R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant