From dc7c728557421dabafed1590edc5f28e28b6c2d7 Mon Sep 17 00:00:00 2001
From: Paul Taylor <paul.e.taylor@me.com>
Date: Thu, 25 Jan 2018 16:05:56 -0800
Subject: [PATCH] add more view, predicate externs

---
 js/gulp/closure-task.js |  3 +-
 js/src/Arrow.externs.js | 80 +++++++++++++++++++++++++++++------------
 js/src/Arrow.ts         |  7 ++--
 3 files changed, 64 insertions(+), 26 deletions(-)

diff --git a/js/gulp/closure-task.js b/js/gulp/closure-task.js
index 9633d7199cf88..0b2ef1b846b81 100644
--- a/js/gulp/closure-task.js
+++ b/js/gulp/closure-task.js
@@ -66,7 +66,8 @@ const createClosureArgs = (entry, externs) => ({
     rewrite_polyfills: false,
     entry_point: `${entry}.js`,
     module_resolution: `NODE`,
-    // formatting: `PRETTY_PRINT`, debug: true,
+    // formatting: `PRETTY_PRINT`,
+    // debug: true,
     compilation_level: `ADVANCED`,
     allow_method_call_decomposing: true,
     package_json_entry_names: `module,jsnext:main,main`,
diff --git a/js/src/Arrow.externs.js b/js/src/Arrow.externs.js
index a3d5fad46880e..a549cae5a7c8b 100644
--- a/js/src/Arrow.externs.js
+++ b/js/src/Arrow.externs.js
@@ -73,6 +73,7 @@ var CountByResult = function() {};
 CountByResult.prototype.asJSON;
 
 var col = function () {};
+var lit = function () {};
 
 var Value = function() {};
 /** @type {?} */
@@ -83,26 +84,35 @@ Value.prototype.lteq;
 Value.prototype.eq;
 
 var Col = function() {};
-
-var Literal = function() {};
-
+/** @type {?} */
+Col.prototype.bind;
+var Or = function() {};
+var And = function() {};
 var GTeq = function () {};
 /** @type {?} */
 GTeq.prototype.and;
 /** @type {?} */
 GTeq.prototype.or;
-
 var LTeq = function () {};
 /** @type {?} */
 LTeq.prototype.and;
 /** @type {?} */
 LTeq.prototype.or;
-
 var Equals = function () {};
 /** @type {?} */
 Equals.prototype.and;
 /** @type {?} */
 Equals.prototype.or;
+var Predicate = function() {};
+/** @type {?} */
+Predicate.prototype.bind;
+/** @type {?} */
+Predicate.prototype.and;
+/** @type {?} */
+Predicate.prototype.or;
+/** @type {?} */
+Predicate.prototype.ands;
+var Literal = function() {};
 
 var TableToStringIterator = function() {};
 /** @type {?} */
@@ -142,8 +152,6 @@ Vector.prototype.get;
 /** @type {?} */
 Vector.prototype.set;
 /** @type {?} */
-Vector.prototype.setData;
-/** @type {?} */
 Vector.prototype.toArray;
 /** @type {?} */
 Vector.prototype.concat;
@@ -465,97 +473,125 @@ var FlatView = function() {};
 /** @type {?} */
 FlatView.prototype.get;
 /** @type {?} */
+FlatView.prototype.clone;
+/** @type {?} */
 FlatView.prototype.isValid;
 /** @type {?} */
 FlatView.prototype.toArray;
 /** @type {?} */
 FlatView.prototype.set;
+
+var PrimitiveView = function() {};
 /** @type {?} */
-FlatView.prototype.setData;
+PrimitiveView.prototype.size;
+/** @type {?} */
+PrimitiveView.prototype.clone;
 
 var NullView = function() {};
 /** @type {?} */
 NullView.prototype.get;
 /** @type {?} */
+NullView.prototype.clone;
+/** @type {?} */
 NullView.prototype.isValid;
 /** @type {?} */
 NullView.prototype.toArray;
 /** @type {?} */
 NullView.prototype.set;
-/** @type {?} */
-NullView.prototype.setData;
 
 var BoolView = function() {};
 /** @type {?} */
 BoolView.prototype.get;
 /** @type {?} */
+BoolView.prototype.clone;
+/** @type {?} */
 BoolView.prototype.isValid;
 /** @type {?} */
 BoolView.prototype.toArray;
 /** @type {?} */
 BoolView.prototype.set;
-/** @type {?} */
-BoolView.prototype.setData;
 
 var ValidityView = function() {};
 /** @type {?} */
 ValidityView.prototype.get;
 /** @type {?} */
+ValidityView.prototype.clone;
+/** @type {?} */
 ValidityView.prototype.isValid;
 /** @type {?} */
 ValidityView.prototype.toArray;
 /** @type {?} */
 ValidityView.prototype.set;
-/** @type {?} */
-ValidityView.prototype.setData;
 
 var DictionaryView = function() {};
 /** @type {?} */
 DictionaryView.prototype.get;
 /** @type {?} */
+DictionaryView.prototype.clone;
+/** @type {?} */
 DictionaryView.prototype.isValid;
 /** @type {?} */
 DictionaryView.prototype.toArray;
 /** @type {?} */
 DictionaryView.prototype.set;
-/** @type {?} */
-DictionaryView.prototype.setData;
 
 var ListViewBase = function() {};
 /** @type {?} */
 ListViewBase.prototype.get;
 /** @type {?} */
+ListViewBase.prototype.clone;
+/** @type {?} */
 ListViewBase.prototype.isValid;
 /** @type {?} */
 ListViewBase.prototype.toArray;
 /** @type {?} */
 ListViewBase.prototype.set;
-/** @type {?} */
-ListViewBase.prototype.setData;
 
 var NestedView = function() {};
 /** @type {?} */
 NestedView.prototype.get;
 /** @type {?} */
+NestedView.prototype.clone;
+/** @type {?} */
 NestedView.prototype.isValid;
 /** @type {?} */
 NestedView.prototype.toArray;
 /** @type {?} */
 NestedView.prototype.set;
-/** @type {?} */
-NestedView.prototype.setData;
 
 var ChunkedView = function() {};
 /** @type {?} */
 ChunkedView.prototype.get;
 /** @type {?} */
+ChunkedView.prototype.clone;
+/** @type {?} */
 ChunkedView.prototype.isValid;
 /** @type {?} */
 ChunkedView.prototype.toArray;
 /** @type {?} */
 ChunkedView.prototype.set;
-/** @type {?} */
-ChunkedView.prototype.setData;
+
+var ListView = function() {};
+var FixedSizeListView = function() {};
+var BinaryView = function() {};
+var Utf8View = function() {};
+var UnionView = function() {};
+var DenseUnionView = function() {};
+var StructView = function() {};
+var MapView = function() {};
+var NullView = function() {};
+var FixedSizeView = function() {};
+var Float16View = function() {};
+var DateDayView = function() {};
+var DateMillisecondView = function() {};
+var TimestampDayView = function() {};
+var TimestampSecondView = function() {};
+var TimestampMillisecondView = function() {};
+var TimestampMicrosecondView = function() {};
+var TimestampNanosecondView = function() {};
+var IntervalYearMonthView = function() {};
+var IntervalYearView = function() {};
+var IntervalMonthView = function() {};
 
 var TypeVisitor = function() {};
 /** @type {?} */
diff --git a/js/src/Arrow.ts b/js/src/Arrow.ts
index 7ebb4d5dc130b..eefed2d9a3099 100644
--- a/js/src/Arrow.ts
+++ b/js/src/Arrow.ts
@@ -155,15 +155,16 @@ export namespace view {
 
 export namespace predicate {
     export import col = predicate_.col;
-    export import Col = predicate_.Col;
-    //export import Value = predicate_.Value;
-    export import Literal = predicate_.Literal;
+    export import lit = predicate_.lit;
 
     export import Or = predicate_.Or;
+    export import Col = predicate_.Col;
     export import And = predicate_.And;
     export import GTeq = predicate_.GTeq;
     export import LTeq = predicate_.LTeq;
+    export import Value = predicate_.Value;
     export import Equals = predicate_.Equals;
+    export import Literal = predicate_.Literal;
     export import Predicate = predicate_.Predicate;
 
     export import PredicateFunc = predicate_.PredicateFunc;