diff --git a/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfig.java b/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfig.java index 5ee65a120b926..36683ae4d3d56 100644 --- a/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfig.java +++ b/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfig.java @@ -79,7 +79,7 @@ public BaseAllocator getAllocator() { * * @return true to include field metadata, false to exclude it. */ - public boolean getIncludeMetadata() { + public boolean shouldIncludeMetadata() { return includeMetadata; } } diff --git a/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowUtils.java b/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowUtils.java index a363c14af88f4..e46afb98a0a0b 100644 --- a/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowUtils.java +++ b/java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowUtils.java @@ -163,8 +163,8 @@ public static Schema jdbcToArrowSchema(ResultSetMetaData rsmd, JdbcToArrowConfig final FieldType fieldType; final Map metadata; - if (config.getIncludeMetadata()) { - metadata = new HashMap(); + if (config.shouldIncludeMetadata()) { + metadata = new HashMap<>(); metadata.put(Constants.SQL_CATALOG_NAME_KEY, rsmd.getCatalogName(i)); metadata.put(Constants.SQL_TABLE_NAME_KEY, rsmd.getTableName(i)); metadata.put(Constants.SQL_COLUMN_NAME_KEY, columnName); diff --git a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfigTest.java b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfigTest.java index a7a2596de01b0..1265678a31230 100644 --- a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfigTest.java +++ b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfigTest.java @@ -96,19 +96,19 @@ public void testConfig() { JdbcToArrowConfigBuilder builder = new JdbcToArrowConfigBuilder(allocator, calendar, false); JdbcToArrowConfig config = builder.build(); - assertFalse(config.getIncludeMetadata()); + assertFalse(config.shouldIncludeMetadata()); builder.setIncludeMetadata(true); config = builder.build(); - assertTrue(config.getIncludeMetadata()); + assertTrue(config.shouldIncludeMetadata()); config = new JdbcToArrowConfigBuilder(allocator, calendar, true).build(); - assertTrue(config.getIncludeMetadata()); + assertTrue(config.shouldIncludeMetadata()); config = new JdbcToArrowConfig(allocator, calendar, true); - assertTrue(config.getIncludeMetadata()); + assertTrue(config.shouldIncludeMetadata()); config = new JdbcToArrowConfig(allocator, calendar, false); - assertFalse(config.getIncludeMetadata()); + assertFalse(config.shouldIncludeMetadata()); } }