Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet list reader not reading correct element lengths #518

Closed
nevi-me opened this issue Jul 3, 2021 · 3 comments
Closed

Parquet list reader not reading correct element lengths #518

nevi-me opened this issue Jul 3, 2021 · 3 comments
Labels
bug parquet Changes to the parquet crate

Comments

@nevi-me
Copy link
Contributor

nevi-me commented Jul 3, 2021

Describe the bug

This is https://issues.apache.org/jira/browse/ARROW-13120 moved here, with a bit more details.

The issue is that the list reader does not check repetitions to calculate the correct number of values to read in order to correctly compose a list.

To Reproduce

Given an array:

{"list": [1, 2, 3]}
{"list": [4, 5]}

Reading 2 values should return the 5 child values, but only 1 and 2 are returned.

Expected behavior

List reader should calculate the correct number of child values to read, then return those values instead of slicing between arrays.

Additional context

This bug seems to have existed before the new arrow reader contributed by @yordan-pavlov

@nevi-me nevi-me added bug parquet Changes to the parquet crate labels Jul 3, 2021
@nevi-me nevi-me changed the title [PLACEHOLDER] Parquet list reader not reading correct element lengths Parquet list reader not reading correct element lengths Jul 11, 2021
@nevi-me
Copy link
Contributor Author

nevi-me commented Jul 11, 2021

@mcassels I've opened this issue to track the bug that you identified

@alamb
Copy link
Contributor

alamb commented Jan 19, 2022

@helgikrs has been recently working on some fixes for this type of issue in #1187 #1166 and #1185 . I wonder if someone could check if it is still an issue

@tustvold
Copy link
Contributor

This does not appear to be an issue anymore, possibly closed by #1588 or some prior pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants