Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy broken after upgrade to rust 1.53 #467

Closed
alamb opened this issue Jun 19, 2021 · 0 comments · Fixed by #470
Closed

Clippy broken after upgrade to rust 1.53 #467

alamb opened this issue Jun 19, 2021 · 0 comments · Fixed by #470
Labels

Comments

@alamb
Copy link
Contributor

alamb commented Jun 19, 2021

Describe the bug
Its that time again: Rust 1.53 was released with improved (aka more stringent) clippy resulting in some new clippy CI failures:

Example run:
https://github.com/apache/arrow-rs/runs/2864727407


    Checking tracing-futures v0.2.5
    Checking futures-executor v0.3.15
    Checking arrow v5.0.0-SNAPSHOT (/__w/arrow-rs/arrow-rs/arrow)
error: usage of `FromIterator::from_iter`
   --> arrow/src/array/array_boolean.rs:150:9
    |
150 |         BooleanArray::from_iter(data.iter())
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `.collect()` instead of `::from_iter()`: `data.iter().collect::<BooleanArray<_>>()`
    |
    = note: `-D clippy::from-iter-instead-of-collect` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_iter_instead_of_collect

@alamb alamb added the bug label Jun 19, 2021
@alamb alamb changed the title Clippy broken after upgrade to rust 1.3 Clippy broken after upgrade to rust 1.53 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant