Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Unsigned Integer for Fixed Size DataType #3815

Closed
tustvold opened this issue Mar 7, 2023 · 1 comment
Closed

Use Unsigned Integer for Fixed Size DataType #3815

tustvold opened this issue Mar 7, 2023 · 1 comment
Assignees
@tustvold
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented Mar 7, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

DataType currently uses i32 for the length of FixedSizeList and FixedSizeBinary.

For consistency with the rest of the rust ecosystem, in addition to arrow2, we should instead use usize.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

#1176
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Mar 7, 2023
@tustvold tustvold self-assigned this Mar 7, 2023
@tustvold tustvold changed the title Use usize for Fixed Size DataType Use Unsigned Integer for Fixed Size DataType Mar 7, 2023
@tustvold
Copy link
Contributor Author

The flatbuffer format defines the length as a 32-bit signed integer, we should be consistent with this

@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
@tustvold tustvold added arrow Changes to the arrow crate development-process Related to development process of arrow-rs labels Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tustvold