Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Duplication in Like Kernels #3296

Closed
tustvold opened this issue Dec 8, 2022 · 3 comments
Closed

Reduce Duplication in Like Kernels #3296

tustvold opened this issue Dec 8, 2022 · 3 comments
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

tustvold commented Dec 8, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The like kernels contain a significant amount of copy-pasted code with very minor modifications for the various like, ilike, nlike, nilike variants. It would be good to reduce this

Describe the solution you'd like

The existing like_scalar_op should allow for significant reduction in the code duplication

Describe alternatives you've considered

Additional context

@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog help wanted labels Dec 8, 2022
@askoa
Copy link
Contributor

askoa commented Dec 8, 2022

I can pick up some of these.

@tustvold
Copy link
Contributor Author

tustvold commented Dec 8, 2022

That would be awesome, thank you 👍

FYI you will want to make sure you are on an up to date master, as #3295 has some non-trivial code movement

@Dandandan
Copy link
Contributor

Good idea 👍. I remember those kernels were non-trivial to change before and are in need of some good cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

No branches or pull requests

3 participants