-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataType::is_numeric
should match the is_numeric
function in Datafusion.
#2611
Comments
DataType::is_numeric
should contains the is_numeric
function in Datafusion.DataType::is_numeric
should match the is_numeric
function in Datafusion.
Hi @alamb, any background of why we don't support |
Because lack of some kernel function for some data type which may be not used by the upstream project or other user, the checker of data type maybe duplicated and redundant. |
Thank you @liukun4515. Then, the next question is that should we update the |
I think f16 support was relatively recent -- added by @jimexist in #888 . I don't think there was any specific reason that f16 doesn't have as wide support as the other types. I would be in favor of having arrow-rs and datafusion match. I think decimal128 is a critical usecase for datafusion - as at least @liukun4515 and his team are using it heavily. I don't know of anyone using f16 at the moment (but maybe there are) so I don't think it is as important |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In datafusion, we have:
We should update
DataType::is_numeric
to contain these constructors so that we could remove the redundantis_numeric
in datafusion (apache/datafusion#1613)Describe the solution you'd like
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: