Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DictionaryArray support in eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn #1201

Closed
alamb opened this issue Jan 18, 2022 · 0 comments · Fixed by #1326
Closed
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Jan 18, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Rationale make it fast and easy (more ergonomic) to compare arrays, both for DataFusion and other users. See rationale in #843

Describe the solution you'd like
The idea would basically be to implement the same thing as @viirya did for timestamp types in #1095 but for DictionaryArrays

That is the following code should not assert and compare the decimal arrays element by element:

let arr1: DictionaryArray<Int32Type> = ...;
let arr2: DictionaryArray<Int32Type> = ...;
let result = eq_dyn(&arr1, &arr2);
assert!(result.is_ok())

Describe alternatives you've considered
For completeness, we could also add eq_dict, neq_dict, etc as well, though I personally think focusing on the dyn kernels would be the easiest thing.

Additional context

other context:
I am trying to move datafusion over to using the dyn kernels here: apache/datafusion#1475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant