Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize take kernel for Decimal #1190

Closed
alamb opened this issue Jan 17, 2022 · 3 comments
Closed

Optimize take kernel for Decimal #1190

alamb opened this issue Jan 17, 2022 · 3 comments

Comments

@alamb
Copy link
Contributor

alamb commented Jan 17, 2022

The idea is to avoid using DecimalBuilder and create the DecimalArray directly using an iterator (or MutableBuffer)

Originally posted by @alamb in #1172 (review)
@alamb alamb mentioned this issue Jan 17, 2022
Merged
@tfeda
Copy link
Contributor

tfeda commented May 22, 2022

This seems to have been resolved in #1249. I think this issue can be closed

@alamb
Copy link
Contributor Author

alamb commented May 23, 2022

Good point @tfeda -- thank you

@alamb alamb closed this as completed May 23, 2022
@alamb
Copy link
Contributor Author

alamb commented May 23, 2022

I think #1223 also is related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alamb @tfeda