Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test coverage of device extension #247

Closed
paleolimbot opened this issue Jun 22, 2023 · 1 comment
Closed

Expand test coverage of device extension #247

paleolimbot opened this issue Jun 22, 2023 · 1 comment

Comments

@paleolimbot
Copy link
Member

In the IPC extension we use Arrow C++ and parameterized tests to efficiently test all types. While in theory all types are currently copyable/movable, only string arrays are currently tested.

To test the metal implementation on CI, would also need a Mac M1 runner (I think the ASF has one); to test the CUDA implementation we need a runner with CUDA (I'm sure this is solved somewhere for Arrow C++).

@paleolimbot
Copy link
Member Author

Closing since we now have CUDA self-hosted runners and because the GitHub actions runners support Metal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant