-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add object_name_to_table_reference in SqlToRel #5155
Conversation
865f433
to
6e12b65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jiacai2050
pub parse_float_as_decimal: bool, default = false | ||
|
||
/// Whether to normalize ident | ||
/// When set to true, sql parser will normalize ident(convert ident to lowercase when not quoted) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
name, | ||
self.options.enable_ident_normalization, | ||
)?; | ||
let table_ref = self.object_name_to_table_reference(name)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -69,3 +69,5 @@ Environment variables are read during `SessionConfig` initialisation so they mus | |||
| datafusion.optimizer.hash_join_single_partition_threshold | 1048576 | The maximum estimated size in bytes for one input side of a HashJoin will be collected into a single partition | | |||
| datafusion.explain.logical_plan_only | false | When set to true, the explain statement will only print logical plans | | |||
| datafusion.explain.physical_plan_only | false | When set to true, the explain statement will only print physical plans | | |||
| datafusion.sql_parser.parse_float_as_decimal | false | When set to true, sql parser will parse float as decimal type | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this too 👍
Benchmark runs are scheduled for baseline = 953d16b and contender = c323721. c323721 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
This is a followup PR for #5124, which add add method in SqlToRel to simplify calls to
object_name_to_table_reference
.What changes are included in this PR?
object_name_to_table_reference
sql_parser
optionsAre these changes tested?
CI itself.
Are there any user-facing changes?
No