Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiskManager to create a spill folder if doesn't exist #5186

Closed
comphead opened this issue Feb 5, 2023 · 0 comments · Fixed by #5185
Closed

DiskManager to create a spill folder if doesn't exist #5186

comphead opened this issue Feb 5, 2023 · 0 comments · Fixed by #5185
Labels
enhancement New feature or request

Comments

@comphead
Copy link
Contributor

comphead commented Feb 5, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

DiskManager will fail if spill directory doesn't exist

    #[test]
    fn test_disk_manager_create_spill_folder() {
        let config = DiskManagerConfig::new_specified(vec!["DOESNT_EXIST".into()]);

        DiskManager::try_new(config)
            .unwrap()
            .create_tmp_file("Testing")
            .unwrap();
    }

panicked at 'called `Result::unwrap()` on an `Err` value: IoError(Custom { kind: NotFound, error: PathError { path: "/DOESNT_EXIST/datafusion-fJMAYo", err: Os { code: 2, kind: NotFound, message: "No such file or directory" } } })', 

Describe the solution you'd like
Create automatically spill folder if doesn't exist

Describe alternatives you've considered
Not doing this
Additional context
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant