Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: As a user, I want to provide a default value for upstream.type, so that we can save lots of typing #8114

Closed
spacewander opened this issue Oct 18, 2022 · 1 comment · Fixed by #8191 or #8180
Closed

feat: As a user, I want to provide a default value for upstream.type, so that we can save lots of typing #8114

spacewander opened this issue Oct 18, 2022 · 1 comment · Fixed by #8191 or #8180
Assignees
@Hazel6869
Labels
good first issue Good for newcomers

Comments

@spacewander
Copy link
Member

Description

Currently, the upstream.type is required when creating an upstream:

apisix/apisix/schema_def.lua

Line 439 in cf8ae8c

type = "string",

We can provide the roundrobin as the default value.
@spacewander spacewander added the good first issue Good for newcomers label Oct 18, 2022
@Hazel6869
Copy link
Contributor

Description

Currently, the upstream.type is required when creating an upstream:

apisix/apisix/schema_def.lua

Line 439 in cf8ae8c

type = "string",

We can provide the roundrobin as the default value.
Hi @spacewander , can you assign this issue to me.

This was referenced Oct 26, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hazel6869 Hazel6869

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@spacewander @Hazel6869