Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ai-content-moderation to ai-aws-content-moderation #12010

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

The current plug-in configuration abstraction turned out to be a bad design choice as the moderation mechanism is hard-coded to plugin logic, if we use other AI content moderation services, there will be huge differences in how the content moderation is done.

So, this PR refactors ai-content-moderation plugin by making it specific for ai-aws-content-moderation.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. plugin labels Feb 28, 2025
@membphis
Copy link
Member

membphis commented Mar 3, 2025

CI failed, pls fix those first

@shreemaan-abhishek
Copy link
Contributor Author

CI failed, pls fix those first

seems like flaky error, I have re-run the CI.

Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the doc too:

image

@membphis
Copy link
Member

membphis commented Mar 5, 2025

ci failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants