-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ai-content-moderation to ai-aws-content-moderation #12010
Open
shreemaan-abhishek
wants to merge
7
commits into
apache:master
Choose a base branch
from
shreemaan-abhishek:refactor-content-moderation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: ai-content-moderation to ai-aws-content-moderation #12010
shreemaan-abhishek
wants to merge
7
commits into
apache:master
from
shreemaan-abhishek:refactor-content-moderation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI failed, pls fix those first |
seems like flaky error, I have re-run the CI. |
membphis
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
membphis
approved these changes
Mar 5, 2025
ci failed |
Revolyssup
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current plug-in configuration abstraction turned out to be a bad design choice as the moderation mechanism is hard-coded to plugin logic, if we use other AI content moderation services, there will be huge differences in how the content moderation is done.
So, this PR refactors
ai-content-moderation
plugin by making it specific forai-aws-content-moderation
.Checklist