From 2a932657cc988ff523f8b01dd286b79f6eb47e38 Mon Sep 17 00:00:00 2001 From: Josh Fell Date: Tue, 18 Jan 2022 10:29:42 -0500 Subject: [PATCH 1/2] Fix Mypy "no attribute" errors in `airflow/contrib/sensors` --- airflow/contrib/sensors/sagemaker_training_sensor.py | 9 +++------ airflow/providers/microsoft/azure/sensors/wasb.pyi | 5 +++++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/airflow/contrib/sensors/sagemaker_training_sensor.py b/airflow/contrib/sensors/sagemaker_training_sensor.py index e8a76506609..6a56516042a 100644 --- a/airflow/contrib/sensors/sagemaker_training_sensor.py +++ b/airflow/contrib/sensors/sagemaker_training_sensor.py @@ -15,17 +15,14 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -"""This module is deprecated. Please use :mod:`airflow.providers.amazon.aws.sensors.sagemaker_training`.""" +"""This module is deprecated. Please use :mod:`airflow.providers.amazon.aws.sensors.sagemaker`.""" import warnings -from airflow.providers.amazon.aws.sensors.sagemaker_training import ( # noqa - SageMakerHook, - SageMakerTrainingSensor, -) +from airflow.providers.amazon.aws.sensors.sagemaker import SageMakerHook, SageMakerTrainingSensor # noqa warnings.warn( - "This module is deprecated. Please use `airflow.providers.amazon.aws.sensors.sagemaker_training`.", + "This module is deprecated. Please use `airflow.providers.amazon.aws.sensors.sagemaker`.", DeprecationWarning, stacklevel=2, ) diff --git a/airflow/providers/microsoft/azure/sensors/wasb.pyi b/airflow/providers/microsoft/azure/sensors/wasb.pyi index 2c8a5251d5b..30a83545dec 100644 --- a/airflow/providers/microsoft/azure/sensors/wasb.pyi +++ b/airflow/providers/microsoft/azure/sensors/wasb.pyi @@ -24,6 +24,7 @@ from typing import Optional +from airflow.providers.sensors.wasb import WasbPrefixSensor from airflow.sensors.base import BaseSensorOperator class WasbBlobSensor(BaseSensorOperator): @@ -41,3 +42,7 @@ class WasbBlobSensor(BaseSensorOperator): check_options: Optional[dict] = None, **kwargs, ) -> None: ... + +# Adding this public module override to suppress Mypy errors stating +# "airflow.providers.microsoft.azure.sensors.wasb has no attribute 'WasbPrefixSensor'". +__all__ = ["WasbBlobSensor", "WasbPrefixSensor"] From 02eb738417a0622dd9cf320b2593162ab089a310 Mon Sep 17 00:00:00 2001 From: Josh Fell Date: Tue, 18 Jan 2022 16:15:33 -0500 Subject: [PATCH 2/2] Revert stub file change for wasb.pyi --- airflow/providers/microsoft/azure/sensors/wasb.pyi | 5 ----- 1 file changed, 5 deletions(-) diff --git a/airflow/providers/microsoft/azure/sensors/wasb.pyi b/airflow/providers/microsoft/azure/sensors/wasb.pyi index 30a83545dec..2c8a5251d5b 100644 --- a/airflow/providers/microsoft/azure/sensors/wasb.pyi +++ b/airflow/providers/microsoft/azure/sensors/wasb.pyi @@ -24,7 +24,6 @@ from typing import Optional -from airflow.providers.sensors.wasb import WasbPrefixSensor from airflow.sensors.base import BaseSensorOperator class WasbBlobSensor(BaseSensorOperator): @@ -42,7 +41,3 @@ class WasbBlobSensor(BaseSensorOperator): check_options: Optional[dict] = None, **kwargs, ) -> None: ... - -# Adding this public module override to suppress Mypy errors stating -# "airflow.providers.microsoft.azure.sensors.wasb has no attribute 'WasbPrefixSensor'". -__all__ = ["WasbBlobSensor", "WasbPrefixSensor"]