Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent change to DbApiHook affects multiple providers #37838

Closed
1 of 8 tasks
ferruzzi opened this issue Mar 1, 2024 · 0 comments · Fixed by #37840
Closed
1 of 8 tasks

Recent change to DbApiHook affects multiple providers #37838

ferruzzi opened this issue Mar 1, 2024 · 0 comments · Fixed by #37840
Labels
area:CI Airflow's tests and continious integration area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet

Comments

@ferruzzi
Copy link
Contributor

ferruzzi commented Mar 1, 2024

Apache Airflow version

2.8.2

If "Other Airflow 2 version" selected, which one?

No response

What happened?

It looks like #37246 has broken the mypy-providers test for multiple providers since they subclass DBApiHook and their insert_rows method signatures no longer match the super()

Providers affected:

  • trino
  • presto
  • oracle
  • google/bigquery
  • apache/pinot
  • apache/druid

Relevant portion of output from breeze static-checks --all-files
image

What you think should happen instead?

I think the insert_rows method in each of those classes need to add executemany to their signatures to match the parent class's signature, but I don't know enough about their particular usecases to know how they should default.

How to reproduce

I noticed it while running breeze static-checks --all-files, I'm sure there are other faster/easier ways to repro it.

Operating System

na

Versions of Apache Airflow Providers

No response

Deployment

Other

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ferruzzi ferruzzi added kind:bug This is a clearly a bug area:CI Airflow's tests and continious integration area:core needs-triage label for new issues that we didn't triage yet labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CI Airflow's tests and continious integration area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant