Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover image is duplicated when playback window is at bottom #498

Closed
diegoulloao opened this issue Jul 8, 2024 · 7 comments · Fixed by #532
Closed

Cover image is duplicated when playback window is at bottom #498

diegoulloao opened this issue Jul 8, 2024 · 7 comments · Fixed by #532
Labels
bug Something isn't working

Comments

@diegoulloao
Copy link

diegoulloao commented Jul 8, 2024

Describe the bug
A duplicated cover image appears inside the playlist when the playback window position is at bottom.

To Reproduce

  1. Set playback window at bottom: playback_window_position = "Bottom"
  2. Play something

Expected behaviour
See a single image in the playback window, no duplicated ones.

Screenshots
Screenshot 6

Environment

  • OS: macOs
  • Application version: 0.19.1 (up to date version)
  • Application features: image, daemon

Additional context

theme = "neofusion"
client_id = "secret"
enable_media_control = true
cover_img_length = 14
page_size_in_rows = 14
playback_window_position = "Bottom"
play_icon = ""
pause_icon = ""

[device]
name = "spotify-player"
device_type = "speaker"
volume = 100
bitrate = 320
audio_cache = false

** Only happening in Kitty terminal (0.35.2).

@diegoulloao diegoulloao added the bug Something isn't working label Jul 8, 2024
@diegoulloao
Copy link
Author

BTW, check this: https://github.com/diegoulloao/neofusion.sp

@aome510
Copy link
Owner

aome510 commented Jul 8, 2024

How frequent does this happen and did it ever happen with the previous version v0.18.2?

Related: #399. I thought I already fixed it before 🤔

@diegoulloao
Copy link
Author

diegoulloao commented Jul 8, 2024

I didn’t check the previous version, I started to change the config after upgrade. I’ll give it a try.

It happens all the time.

@diegoulloao
Copy link
Author

@aome510 is also happening in the previous version 0.18.2

@HiFiveJazz
Copy link

I can also second this bug, I can replicate it on macOS and Linux , given the playback window is at the bottom.

@diegoulloao
Copy link
Author

diegoulloao commented Aug 24, 2024

Screenshot

Issue persists in latest version 0.19.1 @aome510

@aome510
Copy link
Owner

aome510 commented Aug 24, 2024

Screenshot Issue persists in latest version `0.19.1` @aome510

can you try latest main? I haven't released a new version in a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants