-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find module @mui/icons-material in v0.16.26 #729
Comments
Can confirm, same thing Might be related to this: https://github.com/solana-labs/wallet-adapter/pull/728/files#diff-0a9b3997ed030b2a1ffc834f3f7b54133507367ac0e15673c01c2b57ab21b10aR3-R11 or this: 5406167#r101354991 |
Thanks for this, those changes definitely look like they could be causing an issue here so I'd like to take a closer look at this. I'm having trouble reproducing it though, do you have an example repo by any chance? Here's what I tried:
So it looks like using both npm and yarn I can generate the lockfile with the 0.16.26 version without any issues. |
@mcintyre94 I have my own repo which you can start. If it's too bothersome for you, I can strip it off and have you reproduce on a more bare bone version of it: https://github.com/d-reader-organization/d-reader-frontend
One thing to bare in mind, but I don't think it actually affect this issue: I rely on my own utility npm package |
Thanks! I was mis-understanding where the error happens, I thought it was installing/generating lock files. I'm able to repro this on my test next app:
I guess the next mystery is why our example app seems to work, and if that gives any clues for fixing it here. I noticed that it wasn't hardcoded to the latest version as I thought it was, but it continues to work if I change its dependency to |
I have a hunch but can't express myself properly without a PC nearby. I'll look into this in a day or two if the issue persists. Till then maybe (if this is even possible??) unpublish a faulty version to safe a few devs from headaches? |
I just hit this and it nearly killed me. Commenting the I guess I'll keep digging to see what happened here. |
Prediction: this is 1000% going to come down to two mismatched versions of React existing. |
Nope. mui/material-ui#35233 |
It pertains to wallet-adapter-material-ui. I made a post about it on stackoverflow and I essentially had to stick with v0.16.22 to resolve the issue.
https://stackoverflow.com/questions/75504022/cannot-find-node-module-after-deleting-yarn-lock-package-lock-json?noredirect=1#comment133223432_75504022
The text was updated successfully, but these errors were encountered: