Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(msw): support using OpenAPI example/examples fields as MSW values #963

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

GMierzwa
Copy link
Contributor

@GMierzwa GMierzwa commented Oct 9, 2023

Status

READY

Description

Resolves #922.

Adds support for OpenAPI's example and examples fields to be used as MSW values. Handles example refs, as well as every variation of the example/examples fields described in the docs.

@vercel
Copy link

vercel bot commented Oct 9, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel.

@anymaniax first needs to authorize it.

@GMierzwa GMierzwa force-pushed the support-example-fields branch from 0467f15 to 22762aa Compare October 30, 2023 15:07
@GMierzwa
Copy link
Contributor Author

Rebased to fix a conflict.

Copy link
Collaborator

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@melloware melloware merged commit c19e35c into orval-labs:master Oct 30, 2023
2 checks passed
@xaviertholot
Copy link

xaviertholot commented May 16, 2024

Hello, from my tests and what I understand from this PR, it seems like we only mock the first example of a list that could contain several ones. I think it would be an amazing feature to mock all examples in order to avoid having to create custom mocks when performing tests. What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support using OpenAPI example field as MSW value
3 participants