Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zod): proper date handling #1050

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix(zod): proper date handling #1050

merged 1 commit into from
Nov 15, 2023

Conversation

melloware
Copy link
Collaborator

@melloware melloware commented Nov 14, 2023

Status

READY

Fix #889
Fix #971

Added test to prove we are doing the correct thing and added date instead of REGEXP

@melloware melloware added the bug Something isn't working label Nov 14, 2023
@melloware melloware force-pushed the O889 branch 2 times, most recently from d3aa8cc to bc00b43 Compare November 14, 2023 20:36
@melloware melloware changed the title fix(zod): escape regexp properly fix(zod): prove regex is working with test Nov 14, 2023
@melloware melloware added documentation Improvements or additions to documentation and removed bug Something isn't working labels Nov 14, 2023
@melloware melloware changed the title fix(zod): prove regex is working with test fix(zod): proper date handling Nov 14, 2023
@melloware melloware added this to the 6.21.0 milestone Nov 14, 2023
@melloware melloware merged commit 67856c2 into orval-labs:master Nov 15, 2023
2 checks passed
@melloware melloware deleted the O889 branch November 15, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zod: generate wrong validation for type string format date Zod: client generates wrong RegExp
2 participants