Plugin causes segfaults with python 3.12

[graysky2]

Context

Please provide any relevant information about your setup

• Add-on Version: 7.0.6.3
• Kodi Version: latest commit from Omega branch
• Kodi GUI Language: English
• Operating System: Arch Linux
• Operating System Language: English

---

Expected Behavior

Kodi should exit cleanly without segfaulting libpython3.12.so.1.0

---

Current Behavior

Sometimes, when exiting kodi, libpython3.12.so.1.0 segfaults. It is inconsistent however occurring about 30% of the time I exit kodi.

---

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. Setup kodi with this plugin on Arch Linux
2. Start kodi with the systemd kodi service
3. Enable the youtube plugin and play something
4. Stop kodi (which triggers the segfault)

---

Log

Here is the debug log

---

Additional Information

The segfaults do not occur if I disable the youtube plugin.

From journalctl upon stopping kodi:

...
May 12 07:11:47 myth3 (killall)[3498]: pam_unix(login:session): session opened for user kodi(uid=989) by kodi(uid=0)
May 12 07:11:49 myth3 kernel: LanguageInvoker[1774]: segfault at 70fc166e40d0 ip 000070fc34f72d11 sp 000070fbea7ff4c8 error 4 in libpython3.12.so.1.0[70fc34e7c000+266000] likely on CPU 0 (core 0, socket 0)
May 12 07:11:49 myth3 kernel: Code: ff ff 48 89 ee ff d0 e9 cf fe ff ff 66 66 2e 0f 1f 84 00 00 00 00 00 66 90 f3 0f 1e fa 48 8b 57 f0 48 85 d2 74 26 48 8b 4f f8 <48> 8b 42 08 48 83 e1 fc 83 e0 03 48 09 c8 48 89 11 48 89 42 08 48
May 12 07:11:49 myth3 systemd[1]: Created slice Slice /system/systemd-coredump.
May 12 07:11:49 myth3 systemd[1]: Started Process Core Dump (PID 3504/UID 0).
May 12 07:11:50 myth3 systemd-coredump[3505]: [🡕] Process 1737 (kodi.bin) of user 989 dumped core.
                                              
                                              Stack trace of thread 1774:
                                              #0  0x000070fc34f72d11 PyObject_GC_UnTrack (libpython3.12.so.1.0 + 0x172d11)
                                              #1  0x000070fc35074f7b n/a (libpython3.12.so.1.0 + 0x274f7b)
                                              #2  0x000070fc34f88437 n/a (libpython3.12.so.1.0 + 0x188437)
                                              #3  0x000070fc34f774e1 n/a (libpython3.12.so.1.0 + 0x1774e1)
                                              #4  0x000070fc34ffaf01 _PyModule_ClearDict (libpython3.12.so.1.0 + 0x1faf01)
                                              #5  0x000070fc35074b4c n/a (libpython3.12.so.1.0 + 0x274b4c)
                                              #6  0x000070fc350803fe Py_EndInterpreter (libpython3.12.so.1.0 + 0x2803fe)
                                              #7  0x000061834f1c684b _ZN14CPythonInvoker15onExecutionDoneEv (kodi.bin + 0xd6984b)
                                              #8  0x0000618350041046 _ZThn40_N22CLanguageInvokerThread6OnExitEv (kodi.bin + 0x1be4046)
                                              #9  0x000061834f6f5748 _ZN7CThread6ActionEv (kodi.bin + 0x1298748)
                                              #10 0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #11 0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #12 0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #13 0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1737:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a6552 pthread_cond_clockwait (libc.so.6 + 0x92552)
                                              #2  0x000061834f1b8ab6 n/a (kodi.bin + 0xd5bab6)
                                              #3  0x000061834f1c7381 _ZN14CPythonInvoker4stopEb (kodi.bin + 0xd6a381)
                                              #4  0x0000618350051263 _ZN22CLanguageInvokerThread4stopEb (kodi.bin + 0x1bf4263)
                                              #5  0x0000618350044e1e _ZN24CScriptInvocationManager4StopEib (kodi.bin + 0x1be7e1e)
                                              #6  0x0000618350044f54 _ZN24CScriptInvocationManager4StopERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEb (kodi.bin + 0x1be7f54)
                                              #7  0x000061834f92ae47 _ZN12CApplication4StopEi (kodi.bin + 0x14cde47)
                                              #8  0x000061834f92b66b _ZN12CApplication20OnApplicationMessageEPN4KODI9MESSAGING13ThreadMessageE (kodi.bin + 0x14ce66b)
                                              #9  0x000061834f75fdc5 _ZN4KODI9MESSAGING21CApplicationMessenger14ProcessMessageEPNS0_13ThreadMessageE (kodi.bin + 0x1302dc5)
                                              #10 0x000061834f769501 _ZN4KODI9MESSAGING21CApplicationMessenger15ProcessMessagesEv (kodi.bin + 0x130c501)
                                              #11 0x000061834f931a4e _ZN12CApplication7ProcessEv (kodi.bin + 0x14d4a4e)
                                              #12 0x000061834f91d9b1 _ZN12CApplication3RunEv (kodi.bin + 0x14c09b1)
                                              #13 0x000061834f13e7c7 main (kodi.bin + 0xce17c7)
                                              #14 0x000070fc33239c88 n/a (libc.so.6 + 0x25c88)
                                              #15 0x000070fc33239d4c __libc_start_main (libc.so.6 + 0x25d4c)
                                              #16 0x000061834ef9ddd5 _start (kodi.bin + 0xb40dd5)
                                              
                                              Stack trace of thread 1750:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a6552 pthread_cond_clockwait (libc.so.6 + 0x92552)
                                              #2  0x000061834f1b8ab6 n/a (kodi.bin + 0xd5bab6)
                                              #3  0x0000618350281c33 _ZN8ActiveAE9CActiveAE7ProcessEv (kodi.bin + 0x1e24c33)
                                              #4  0x000061834f6f573f _ZN7CThread6ActionEv (kodi.bin + 0x129873f)
                                              #5  0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #6  0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #7  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #8  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1758:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a6552 pthread_cond_clockwait (libc.so.6 + 0x92552)
                                              #2  0x000061834f1b8ab6 n/a (kodi.bin + 0xd5bab6)
                                              #3  0x000061834fe20781 _ZN11PERIPHERALS13CEventScanner7ProcessEv (kodi.bin + 0x19c3781)
                                              #4  0x000061834f6f573f _ZN7CThread6ActionEv (kodi.bin + 0x129873f)
                                              #5  0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #6  0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #7  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #8  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1749:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9)
                                              #2  0x000070fc2d6863fc n/a (iris_dri.so + 0x863fc)
                                              #3  0x000070fc2d69ec2c n/a (iris_dri.so + 0x9ec2c)
                                              #4  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #5  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1757:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a6552 pthread_cond_clockwait (libc.so.6 + 0x92552)
                                              #2  0x000061834f1b8ab6 n/a (kodi.bin + 0xd5bab6)
                                              #3  0x000061834fe3ff37 _ZN11PERIPHERALS14CPeripheralBus7ProcessEv (kodi.bin + 0x19e2f37)
                                              #4  0x000061834f6f573f _ZN7CThread6ActionEv (kodi.bin + 0x129873f)
                                              #5  0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #6  0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #7  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #8  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1759:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a6552 pthread_cond_clockwait (libc.so.6 + 0x92552)
                                              #2  0x000061834f1b8ab6 n/a (kodi.bin + 0xd5bab6)
                                              #3  0x000061834f6eaf91 _ZN6CTimer7ProcessEv (kodi.bin + 0x128df91)
                                              #4  0x000061834f6f573f _ZN7CThread6ActionEv (kodi.bin + 0x129873f)
                                              #5  0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #6  0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #7  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #8  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1740:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9)
                                              #2  0x000070fc334d5e61 __gthread_cond_wait (libstdc++.so.6 + 0xd5e61)
                                              #3  0x000061834f6f4d6c n/a (kodi.bin + 0x1297d6c)
                                              #4  0x00006183500b119f _ZN12ANNOUNCEMENT20CAnnouncementManager7ProcessEv (kodi.bin + 0x1c5419f)
                                              #5  0x000061834f6f573f _ZN7CThread6ActionEv (kodi.bin + 0x129873f)
                                              #6  0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #7  0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #8  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #9  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1748:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9)
                                              #2  0x000070fc2d6863fc n/a (iris_dri.so + 0x863fc)
                                              #3  0x000070fc2d69ec2c n/a (iris_dri.so + 0x9ec2c)
                                              #4  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #5  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1762:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a6552 pthread_cond_clockwait (libc.so.6 + 0x92552)
                                              #2  0x000061834f1b8ab6 n/a (kodi.bin + 0xd5bab6)
                                              #3  0x000061834f6eaf91 _ZN6CTimer7ProcessEv (kodi.bin + 0x128df91)
                                              #4  0x000061834f6f573f _ZN7CThread6ActionEv (kodi.bin + 0x129873f)
                                              #5  0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #6  0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #7  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #8  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1747:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9)
                                              #2  0x000070fc2d6863fc n/a (iris_dri.so + 0x863fc)
                                              #3  0x000070fc2d69ec2c n/a (iris_dri.so + 0x9ec2c)
                                              #4  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #5  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1746:
                                              #0  0x000070fc332a34e9 n/a (libc.so.6 + 0x8f4e9)
                                              #1  0x000070fc332a5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9)
                                              #2  0x000070fc2d6863fc n/a (iris_dri.so + 0x863fc)
                                              #3  0x000070fc2d69ec2c n/a (iris_dri.so + 0x9ec2c)
                                              #4  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #5  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1752:
                                              #0  0x000070fc3331c39d __poll (libc.so.6 + 0x10839d)
                                              #1  0x000061834f28690b _ZN15CFDEventMonitor7ProcessEv (kodi.bin + 0xe2990b)
                                              #2  0x000061834f6f573f _ZN7CThread6ActionEv (kodi.bin + 0x129873f)
                                              #3  0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #4  0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #5  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #6  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1751:
                                              #0  0x000070fc333259ed ioctl (libc.so.6 + 0x1119ed)
                                              #1  0x000070fc34711a77 n/a (libasound.so.2 + 0x48a77)
                                              #2  0x000061835029c59b _ZN11CAESinkALSA10AddPacketsEPPhjj (kodi.bin + 0x1e3f59b)
                                              #3  0x00006183502add6d _ZN8ActiveAE13CActiveAESink13OutputSamplesEPNS_13CSampleBufferE (kodi.bin + 0x1e50d6d)
                                              #4  0x00006183502b0239 _ZN8ActiveAE13CActiveAESink12StateMachineEiPN5Actor8ProtocolEPNS1_7MessageE (kodi.bin + 0x1e53239)
                                              #5  0x00006183502b051a _ZN8ActiveAE13CActiveAESink7ProcessEv (kodi.bin + 0x1e5351a)
                                              #6  0x000061834f6f573f _ZN7CThread6ActionEv (kodi.bin + 0x129873f)
                                              #7  0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #8  0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #9  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #10 0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              
                                              Stack trace of thread 1756:
                                              #0  0x000070fc3331c39d __poll (libc.so.6 + 0x10839d)
                                              #1  0x000061834f27849c _ZN11PERIPHERALS17CPeripheralBusUSB13WaitForUpdateEv (kodi.bin + 0xe1b49c)
                                              #2  0x000061834f2786f1 _ZN11PERIPHERALS17CPeripheralBusUSB7ProcessEv (kodi.bin + 0xe1b6f1)
                                              #3  0x000061834f6f573f _ZN7CThread6ActionEv (kodi.bin + 0x129873f)
                                              #4  0x000061834f6f5a04 n/a (kodi.bin + 0x1298a04)
                                              #5  0x000070fc334e0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84)
                                              #6  0x000070fc332a6ded n/a (libc.so.6 + 0x92ded)
                                              #7  0x000070fc3332a0dc n/a (libc.so.6 + 0x1160dc)
                                              ELF object binary architecture: AMD x86-64
May 12 07:11:50 myth3 systemd[1]: systemd-coredump@0-3504-0.service: Deactivated successfully.
May 12 07:11:50 myth3 xinit[1732]: /usr/bin/kodi: line 215:  1737 Segmentation fault      (core dumped) ${KODI_BINARY} ${ENV_ARGS} $SAVED_ARGS
May 12 07:11:50 myth3 xinit[1732]: Crash report available at /var/lib/kodi/kodi_crashlog-20240512_071150.log

---

[MoojMidge]

See xbmc/xbmc#24440

Can attempt to test the fix in the linked cPython issue if you are able to:
python/cpython#118618

[graysky2]

Thanks for point me to that. Building 3.12 with that PR applied seems to have fixed it!