Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to published @voxpelli/semver-set #27

Open
voxpelli opened this issue May 11, 2023 · 2 comments
Open

Move to published @voxpelli/semver-set #27

voxpelli opened this issue May 11, 2023 · 2 comments

Comments

@voxpelli
Copy link

I noticed that this project is depending on a git commit of my module (added in #10) rather the now published version of it.

Also: Its now no longer a fork but a rewritten standalone project that preserves compatibility: https://www.npmjs.com/package/@voxpelli/semver-set

And since I use it myself in installed-check-core I'm maintaining it and ensuring it keeps working.

@anvaka
Copy link
Owner

anvaka commented May 13, 2023

Thank you for the heads up!

I tried to quickly switch to your version, but running into compatibility issues:

/Users/anvaka/projects/ngraph/experiments/npmrank/countVersions.js:2
var intersect = require('@voxpelli/semver-set').intersect;
                ^

Error [ERR_REQUIRE_ESM]: require() of ES Module 

@voxpelli
Copy link
Author

Right, yeah, you would have to do var { intersect } = await import('@voxpelli/semver-set');, but that would be hard as its currently used in a non-async context :/

Sorry for making it an ESM module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants