Theme restructure #2556

Zo-Bro-23 · 2023-03-01T07:19:25Z

Some themes have names with hyphens, and others have names with underscores. This is slightly confusing, so I thought we'd have names with both hyphens and underscores moving forward. @rickstaa what do you think?

vercel · 2023-03-01T07:19:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
github-readme-stats	✅ Ready (Inspect)	Visit Preview	Mar 1, 2023 at 7:21AM (UTC)

rickstaa · 2023-03-01T07:27:28Z

@Zo-Bro-23 I'm okay with this if we make it back-compatible, meaning that we parse themes so that regardless of whether people use a hyphen or underscore, the card works 👍🏻.

Zo-Bro-23 · 2023-03-01T07:29:11Z

That's what I was trying to do with this PR. Parsing cards with hyphens and underscores works, but as a temporary solution I'm just creating duplicate theme names with hyphens and underscores. What do you think of that? Is it just better to take the time to modify the theme parsing instead of doing this?

Zo-Bro-23 · 2023-03-01T07:35:17Z

#2558 is another way to do this. @rickstaa let me know which one you prefer.

rickstaa · 2023-03-01T07:39:52Z

#2558 is another way to do this. @rickstaa let me know which one you prefer.

I would love the combination. Making it consistent and back compatible 😄.

rickstaa

Not Found

rickstaa

End of input while parsing an object (missing '}') at line 1,153 >>> "default-repocard": ...

rickstaa

End of input while parsing an object (missing '}') at line 1,153 >>> "default-repocard": ...

rickstaa

Something went wrong: Theme JSON file could not be parsed: Error: End of input while parsing an object (missing '}') at line 1,153 >>> "default-repocard": ...

rickstaa

Something went wrong in the theme preview action: Theme JSON file could not be parsed: End of input while parsing an object (missing '}') at line 1,153 >>> "default-repocard": ...

github-actions

Something went wrong in the theme preview action: Theme JSON file could not be parsed: End of input while parsing an object (missing '}') at line 1,153 >>> "default-repocard": ...

rickstaa · 2023-03-03T15:37:05Z

@rickstaa the JSON seems to be valid. What do you think?

PS: The error feature is awesome. Thanks for adding it :)

Mm I'm not sure maybe

@rickstaa the JSON seems to be valid. What do you think?

PS: The error feature is awesome. Thanks for adding it :)

Probably my regex not being inclusive enough you changed a lot of things:

github-readme-stats/scripts/preview-theme.js

Lines 298 to 304 in 1e61f9f

    
           parsedJson[0] = "},"; 
        
           if (!/\s*}\s*,?\s*$/.test(parsedJson[1])) { 
        
             parsedJson.push(parsedJson.shift()); 
        
           } else { 
        
             parsedJson.shift(); 
        
           } 
        
           return Hjson.parse(parsedJson.join(""));

Zo-Bro-23 · 2023-03-03T15:38:15Z

@rickstaa the JSON seems to be valid. What do you think?
PS: The error feature is awesome. Thanks for adding it :)

Mm I'm not sure maybe

@rickstaa the JSON seems to be valid. What do you think?
PS: The error feature is awesome. Thanks for adding it :)

Probably my regex not being inclusive enough you changed a lot of things:

github-readme-stats/scripts/preview-theme.js

Lines 298 to 304 in 1e61f9f

parsedJson[0] = "},";

if (!/\s*}\s*,?\s*$/.test(parsedJson[1])) {

parsedJson.push(parsedJson.shift());

} else {

parsedJson.shift();

}

return Hjson.parse(parsedJson.join(""));

Maybe... Can you try making it a bit more lenient?

rickstaa · 2023-03-04T14:16:43Z

@rickstaa the JSON seems to be valid. What do you think?
PS: The error feature is awesome. Thanks for adding it :)

Mm I'm not sure maybe

@rickstaa the JSON seems to be valid. What do you think?
PS: The error feature is awesome. Thanks for adding it :)

Probably my regex not being inclusive enough you changed a lot of things:

github-readme-stats/scripts/preview-theme.js

Lines 298 to 304 in 1e61f9f

parsedJson[0] = "},";

if (!/\s*}\s*,?\s*$/.test(parsedJson[1])) {

parsedJson.push(parsedJson.shift());

} else {

parsedJson.shift();

}

return Hjson.parse(parsedJson.join(""));

Maybe... Can you try making it a bit more lenient?

@Zo-Bro-23 I currently sadly do not have much time to improve it myself. Feel free to suggest a PR for me to review 👍🏻.

github-actions

Something went wrong in the theme preview action: Theme JSON file could not be parsed: End of input while parsing an object (missing '}') at line 1,153 >>> "default-repocard": ...

Zo-Bro-23 · 2023-03-05T10:36:45Z

@rickstaa what commit broke the action? Maybe we should revert it to its previous version.

rickstaa · 2023-03-05T10:47:55Z

@rickstaa what commit broke the action? Maybe we should revert it to its previous version.

No commit broke the action. It is just not equipped yet to handle the mount of changes you made 😅. I will take a quick look.

rickstaa · 2023-03-05T12:31:20Z

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

❌ Theme PR does not adhere to our guidelines.

Test results

❌ default-repocard
❌ gruvbox-light
✔️ vue_dark
❌ shades_of_purple
✔️ blue_green
✔️ great_gatsby
❌ solarized_dark
❌ solarized_light
✔️ chartreuse_dark
✔️ material_palenight
✔️ vision_friendly_dark
✔️ ayu_mirage
❌ midnight_purple
❌ flag_india
❌ kacho-ga
❌ ocean-dark
❌ city-lights
❌ github-dark
❌ discord-old-blurple
❌ aura-dark
❌ noctis-minimus
❌ rose-pine
❌ date-night
❌ one-dark-pro
❌ holi-theme

Result: ❌ Some themes are invalid.

Unfortunately, your theme PR contains an error or does not adhere to our theme guidelines. Please fix the issues below, and we will review your
PR again. This pull request will automatically close in 20 days if no changes are made. After this time, you must re-open the PR for it to be reviewed.

Details

Default-repocard theme preview

⚠️ Theme name isn't in snake_case.
⚠️ title_color does not pass AA contrast ratio.

title_color: #2f80ed | icon_color: #586069 | text_color: #434d58 | bg_color: #fffefe

Theme restructure #2556

Theme restructure #2556

Conversation

Zo-Bro-23 commented Mar 1, 2023

vercel bot commented Mar 1, 2023 • edited Loading

rickstaa commented Mar 1, 2023

Zo-Bro-23 commented Mar 1, 2023 • edited Loading

Zo-Bro-23 commented Mar 1, 2023

rickstaa commented Mar 1, 2023

rickstaa left a comment

Choose a reason for hiding this comment

rickstaa left a comment

Choose a reason for hiding this comment

rickstaa left a comment

Choose a reason for hiding this comment

rickstaa left a comment

Choose a reason for hiding this comment

rickstaa left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

rickstaa commented Mar 3, 2023

Zo-Bro-23 commented Mar 3, 2023

rickstaa commented Mar 4, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

Zo-Bro-23 commented Mar 5, 2023

rickstaa commented Mar 5, 2023

rickstaa commented Mar 5, 2023

Automated Theme Preview

Test results

Details

Default-repocard theme preview

Gruvbox-light theme preview

Vue_dark theme preview

Shades_of_purple theme preview

Blue_green theme preview

Great_gatsby theme preview

Solarized_dark theme preview

Solarized_light theme preview

Chartreuse_dark theme preview

Material_palenight theme preview

Vision_friendly_dark theme preview

Ayu_mirage theme preview

Midnight_purple theme preview

Flag_india theme preview

Kacho-ga theme preview

Ocean-dark theme preview

City-lights theme preview

Github-dark theme preview

Discord-old-blurple theme preview

Aura-dark theme preview

Noctis-minimus theme preview

Rose-pine theme preview

Date-night theme preview

One-dark-pro theme preview

Holi-theme theme preview

rickstaa left a comment

Choose a reason for hiding this comment

Zo-Bro-23 commented Mar 6, 2023

rickstaa commented Mar 6, 2023

github-actions bot commented Mar 29, 2023

github-actions bot commented Mar 29, 2023 • edited Loading

Automated Theme Preview

Test results

Details

Default-repocard theme preview

Gruvbox-light theme preview

Vue_dark theme preview

Shades_of_purple theme preview

Blue_green theme preview

Great_gatsby theme preview

Solarized_dark theme preview

Solarized_light theme preview

Chartreuse_dark theme preview

Material_palenight theme preview

Vision_friendly_dark theme preview

Ayu_mirage theme preview

Midnight_purple theme preview

Flag_india theme preview

vercel bot commented Mar 1, 2023 •

edited

Loading

Zo-Bro-23 commented Mar 1, 2023 •

edited

Loading

github-actions bot commented Mar 29, 2023 •

edited

Loading