Fix NaN and undefined for empty profiles #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty profile used to show "undefined" as the rank. Now empty profile shows "A+"... is B+ possible?
|
@adil192 is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
|
@adil192 Very nice catch! LGTM. |
|
Merged into the master branch. Thanks for your contribution 🚀. |
SousaPedro11
pushed a commit
to SousaPedro11/github-readme-stats
that referenced
this pull request
Aug 29, 2022
* totalCommits: don't return NaN * rank: B+ should cover everyone Empty profile used to show "undefined" as the rank. Now empty profile shows "A+"... is B+ possible?
infinity-plus
pushed a commit
to infinity-plus/github-readme-stats
that referenced
this pull request
Sep 24, 2022
* totalCommits: don't return NaN * rank: B+ should cover everyone Empty profile used to show "undefined" as the rank. Now empty profile shows "A+"... is B+ possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On new/empty GitHub profiles, the card would previously appear like this with
include_all_commitsenabled...And now it has the same behaviour as without
include_all_commits...