Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't show any languages and can't remove border from repo card #468

Closed
Bas950 opened this issue Sep 17, 2020 · 8 comments
Closed

Doesn't show any languages and can't remove border from repo card #468

Bas950 opened this issue Sep 17, 2020 · 8 comments
Labels
stale Issue is marked as stale.

Comments

@Bas950
Copy link
Contributor

Bas950 commented Sep 17, 2020

Describe the bug
On my language card it doesn't show any languages, its empty.
On the pin card the border isn't gone.

Expected behavior
Show the languages and remove the border

Screenshots / Live demo link (paste the github-readme-stats link as markdown image)
https://github.com/Bas950/Bas950
Links used:
https://github-readme-stats.vercel.app/api/top-langs/?username=Bas950&hide_border=true&show_icons=true&theme=dark
https://github-readme-stats.vercel.app/api/pin/?username=PreMiD&repo=Presences&show_icons=true&hide_border=true&theme=dark
image

@anuraghazra
Copy link
Owner

I don't think we can add count_forks option since if we do that then, if some users forked any big third party lib it would also get counted which would make the stats wrong.

@Bas950
Copy link
Contributor Author

Bas950 commented Sep 20, 2020

I don't think we can add count_forks option since if we do that then, if some users forked any big third party lib it would also get counted which would make the stats wrong.

Will see if I can make a exclude_repo for it

@anuraghazra
Copy link
Owner

I don't think we can add count_forks option since if we do that then, if some users forked any big third party lib it would also get counted which would make the stats wrong.

Will see if I can make a exclude_repo for it

We won't support any forks in here, since it would just make the API surface very wide. we cannot make it opt-in. we can although make it opt-out.

@Bas950
Copy link
Contributor Author

Bas950 commented Sep 20, 2020

I don't think we can add count_forks option since if we do that then, if some users forked any big third party lib it would also get counted which would make the stats wrong.

Will see if I can make a exclude_repo for it

We won't support any forks in here, since it would just make the API surface very wide. we cannot make it opt-in. we can although make it opt-out.

I updated the PR, I made an exclude_repo, but do you want me to make the count_forks a opt-out instead of opt-in?
Or how do you wish for me to make it.

@Bas950
Copy link
Contributor Author

Bas950 commented Sep 23, 2020

Hey @anuraghazra, would you want me to make it always get the forks, and then make it opt-out? (just by checking is "isFork" == true that is returned from the graphql). I also made an exclude_repo so you can exclude repositories from being counted towards the languages.

@Bas950
Copy link
Contributor Author

Bas950 commented Sep 24, 2020

Repo card hide border merged in #488

@Bas950
Copy link
Contributor Author

Bas950 commented Sep 27, 2020

Top Langs exclude repo merged in #493

@stale
Copy link

stale bot commented Dec 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is marked as stale. label Dec 6, 2020
@stale stale bot closed this as completed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue is marked as stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants