Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composition): fix composition lost chart value options #5995

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

li1615882553
Copy link
Contributor

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

解决问题:
fixes #5783 修复当 root 是一个 composition node 时候,丢失chart options的问题

解决方案:
当检测到跟节点是composition node的时候,将chart配置的 VIEW_KEYS 下发到composition中

修改后:

Dec-29-2023.19-34-18.mp4

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

解决得很优雅,有一个小点注意一下哈。

src/api/utils.ts Outdated Show resolved Hide resolved
@pearmini pearmini merged commit 7792a37 into antvis:v5 Jan 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: spaceFlex 模式下 chart 的 autoFit 配置无效
2 participants