Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chart.theme as unrequired params #4940

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

pepper-nice
Copy link
Contributor

描述

theme 属性支持在 chart.options() 里申明:

const chart = new Chart({ container });

chart.options({
  theme: 'classic',
  type: 'line',
  clip: true,
  data: {
    type: 'fetch',
    value: 'data/aapl.csv',
  },
  encode: {
    x: 'date',
    y: 'close',
  },
});

chart.render();

@pepper-nice pepper-nice requested a review from pearmini May 5, 2023 02:15
@pepper-nice pepper-nice merged commit 0878230 into v5 May 5, 2023
@pepper-nice pepper-nice deleted the fix/theme-as-unrequire branch May 5, 2023 02:38
hustcc pushed a commit that referenced this pull request May 16, 2023
hustcc pushed a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants