fix: fix issue that legend category cannot update shape (#4968)

* fix: fix issue that legend category cannot update shape * test: update test case
antvis · May 10, 2023 · 152bc18 · 152bc18
1 parent 5258a6e
commit 152bc18
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/__tests__/integration/snapshots/api/chartChangeSize.png b/__tests__/integration/snapshots/api/chartChangeSize.png
diff --git a/__tests__/plots/api/chart-change-size.ts b/__tests__/plots/api/chart-change-size.ts
@@ -18,6 +18,8 @@ export function chartChangeSize(context) {
     { genre: 'Strategy', sold: 115 },
     { genre: 'Action', sold: 120 },
     { genre: 'Shooter', sold: 350 },
+    { genre: 'Infantry', sold: 220 },
+    { genre: 'Logistics', sold: 330 },
     { genre: 'Other', sold: 150 },
   ]);
 

diff --git a/src/component/legendCategory.ts b/src/component/legendCategory.ts
@@ -19,7 +19,7 @@ import { useMarker } from '../utils/marker';
 import {
   adaptor,
   domainOf,
-  G2Layout,
+  LegendCategoryLayout,
   inferComponentLayout,
   inferComponentShape,
   scaleOf,
@@ -244,7 +244,7 @@ export const LegendCategory: GCC<LegendCategoryOptions> = (options) => {
     };
 
     const { legend: legendTheme = {} } = theme;
-    const layoutWrapper = new G2Layout({
+    const layoutWrapper = new LegendCategoryLayout({
       style: {
         x: bbox.x,
         y: bbox.y,

diff --git a/src/component/utils.ts b/src/component/utils.ts
@@ -90,6 +90,13 @@ export class G2Layout extends Layout {
   }
 }
 
+export class LegendCategoryLayout extends Layout {
+  update(options: any) {
+    this.attr(options);
+    (this.children?.[0] as any)?.update(options);
+  }
+}
+
 export function scaleOf(scales: Scale[], type: string): Scale | undefined {
   return scales.filter((s) => s.getOptions().name === type)?.[0];
 }