Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlays layers not working since v0.7.2+822 #2010

Closed
Cheerpipe opened this issue May 14, 2020 · 3 comments · Fixed by #2012
Closed

Overlays layers not working since v0.7.2+822 #2010

Cheerpipe opened this issue May 14, 2020 · 3 comments · Fixed by #2012
Labels
Type: Bug This issue/PR is related to unexpected behaviour in the program.

Comments

@Cheerpipe
Copy link

Overlays layers are not working since v0.7.2+822.

Away effects are not working too since the same build.

https://youtu.be/57gmJuta7vA

Expected Behaviour

  • Overlay layers should be showed if an application with overlays in their profile is running.

Actual Behaviour

Overlay layers are not showed or are ignored.

Reproduction steps

  • Create new profile.
  • Create an overlay layer.
  • Open the application.
  • Overlay should be showed, instead, overlay layers are ignored.

Frequency

Always

Aurora Version:

clean v0.7.2+822 downloaded from appveyor.

Previously an Issue?

Working fine until v0.7.2+821

@Cheerpipe Cheerpipe added the Type: Bug This issue/PR is related to unexpected behaviour in the program. label May 14, 2020
@diogotr7
Copy link
Collaborator

diogotr7 commented May 14, 2020

This is indeed an issue, i did not notice since the built-in profiles display overlays correctly this is not correct. Only the desktop overlay layers work correctly. Caused by #1997 , will investigate.

@xQwexx
Copy link
Contributor

xQwexx commented May 14, 2020

It happening because the sequence was deleted, where the overlays are applied,
but for some reason in the desktop case the overlay applied in the regular layer applying function as well.

@Wibble199 Wibble199 linked a pull request May 15, 2020 that will close this issue
@Cheerpipe
Copy link
Author

The following is working as expected now:

Overlays
Away effect
Process running gamestate conditional

Thanks for your amazing work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug This issue/PR is related to unexpected behaviour in the program.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants