Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Bitmap View #1931

Closed
stdedos opened this issue Mar 12, 2020 · 11 comments
Closed

Keyboard Bitmap View #1931

stdedos opened this issue Mar 12, 2020 · 11 comments
Labels
Type: Enhancement This issue/PR is related to a new feature for the program.

Comments

@stdedos
Copy link

stdedos commented Mar 12, 2020

  • Add a more direct button to open it (instead of going all the way down to debug)
    (could be toggle-able)

  • Could this look less like I need to wear glasses? (could be toggle-able)
    image

    I understand it needs to "immitate" what is shown on the devices (hence I am not expecting crisp QHD), but at some improvement.

@stdedos stdedos added the Type: Enhancement This issue/PR is related to a new feature for the program. label Mar 12, 2020
@diogotr7
Copy link
Collaborator

You can increase the quality of the bitmap in the settings but I wouldn't recommend it. Some of the layers don't render exactly the same for different quality values.

@stdedos
Copy link
Author

stdedos commented Mar 12, 2020

Oh, okay, now I see what are you talking about.

I don't know how internals work; I was hoping that bitmap view itself would be "finely rendered" (or: great and above), without "affecting anything else".

I understand your point, but it is always not easy to track it continuously. I don't want to close this, but I don't see how could this be fixed (maybe "lock" rendering / window in a reasonable size, and then apply "beautification" above it?)

@gitmacer
Copy link
Contributor

About direct button. I am working on auto open of the debug window + remember position... Will be greate if you want to test changes that require a restart.

@stdedos
Copy link
Author

stdedos commented Mar 24, 2020

image

I am most definite you could render a 48x48px topmost Mario-QuestionMark button on the lower right corner of the window that would open debug view immediately. Default off (if you have to); user configurable.

@gitmacer
Copy link
Contributor

If we add a more direct button I would prefer right clicking the settings icon and be able to choose which one. Opinions?

@stdedos
Copy link
Author

stdedos commented Mar 25, 2020

Right-clicking the cog wheel at the bottom right with a quick-access menu doesn't sound half-bad either

@gitmacer
Copy link
Contributor

@stdedos Is that what you wanted?

@stdedos
Copy link
Author

stdedos commented Mar 27, 2020

Sounds like it 👍

@gitmacer
Copy link
Contributor

gitmacer commented Mar 27, 2020

Feel free to test/use it. And report any Bug. If your profiles are important to you please back up them under %appdata%
https://ci.appveyor.com/project/antonpup/aurora/builds/31773909/artifacts

@stdedos
Copy link
Author

stdedos commented Mar 27, 2020

I have already reported enough bugs 😛

https://github.com/antonpup/Aurora/issues/stdedos

And to quote myself: #1897 (comment)

Program crashes a lot for me, it leaks a lot of memory, and I need to restart it daily, to get "half" the features.

So, no, not out of the blue, but I cannot really tell what did I do, what is to blame, or how to reproduce it. I was actually thinking that it had crashed silently, and I didn't bother to restart it; however, it crashed.

@diogotr7
Copy link
Collaborator

diogotr7 commented Apr 3, 2020

Just merged #1943

As for the antialiasing on the bitmap window, i dont think applying effects to the bitmap window and not to the keyboard makes sense, as it would defeat the purpose of it being a preview.

@diogotr7 diogotr7 closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This issue/PR is related to a new feature for the program.
Projects
None yet
Development

No branches or pull requests

3 participants