Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming the model attribute ? #64

Open
dennym opened this issue Sep 23, 2022 · 1 comment
Open

Renaming the model attribute ? #64

dennym opened this issue Sep 23, 2022 · 1 comment

Comments

@dennym
Copy link

dennym commented Sep 23, 2022

Heyhey

I'm pretty sure that the model attribute either comes from the ruby world or the old days when phoenix tried to be more like ruby on rails and had models.
Wouldn't it to make sense to rename that attribute to schema since its basically just testing the schema and the changesets of it?

Just wondering why it did not happened yet or if there is a specific reason you stuck with the model.

If there is interest for it I surely can provide a pull request for it.

best
Denny

@antonmi
Copy link
Owner

antonmi commented Sep 28, 2022

Hey Denny!
You are right, "model" is a ruby legacy :)
Feel free to provide PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants