From 6fed94bc3a1fcb5626556bf43393d0de31e46006 Mon Sep 17 00:00:00 2001 From: Antonio Santos Izaguirre Date: Fri, 21 Oct 2022 21:59:47 +0200 Subject: [PATCH] fixed #584 --- .../rometools/rome/feed/synd/impl/ConverterForRSS094.java | 1 + .../com/rometools/rome/unittest/TestSyndFeedRSS091N.java | 7 +++++++ .../com/rometools/rome/unittest/TestSyndFeedRSS094.java | 1 + .../com/rometools/rome/unittest/issues/Issue2Test.java | 3 ++- 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/rome-core/src/main/java/com/rometools/rome/feed/synd/impl/ConverterForRSS094.java b/rome-core/src/main/java/com/rometools/rome/feed/synd/impl/ConverterForRSS094.java index e97d2d4eb..6ea6a2744 100644 --- a/rome-core/src/main/java/com/rometools/rome/feed/synd/impl/ConverterForRSS094.java +++ b/rome-core/src/main/java/com/rometools/rome/feed/synd/impl/ConverterForRSS094.java @@ -112,6 +112,7 @@ protected SyndEntry createSyndEntry(final Item item, final boolean preserveWireI comments.setRel("comments"); comments.setHref(item.getComments()); comments.setType("text/html"); + syndEntry.getLinks().add(comments); } return syndEntry; diff --git a/rome-core/src/test/java/com/rometools/rome/unittest/TestSyndFeedRSS091N.java b/rome-core/src/test/java/com/rometools/rome/unittest/TestSyndFeedRSS091N.java index 74ba38810..865cce17f 100644 --- a/rome-core/src/test/java/com/rometools/rome/unittest/TestSyndFeedRSS091N.java +++ b/rome-core/src/test/java/com/rometools/rome/unittest/TestSyndFeedRSS091N.java @@ -73,6 +73,13 @@ public void testImageDescription() throws Exception { assertProperty(this.getCachedSyndFeed().getImage().getDescription(), "channel.image.description"); } + public void testItem() throws Exception { + final List items = this.getCachedSyndFeed().getEntries(); + for (int i = 0; i < items.size(); i++) { + testItem(i); + } + } + protected void testItem(final int i) throws Exception { final List items = this.getCachedSyndFeed().getEntries(); final SyndEntry entry = items.get(i); diff --git a/rome-core/src/test/java/com/rometools/rome/unittest/TestSyndFeedRSS094.java b/rome-core/src/test/java/com/rometools/rome/unittest/TestSyndFeedRSS094.java index c62b9f071..e18073382 100644 --- a/rome-core/src/test/java/com/rometools/rome/unittest/TestSyndFeedRSS094.java +++ b/rome-core/src/test/java/com/rometools/rome/unittest/TestSyndFeedRSS094.java @@ -50,6 +50,7 @@ protected void testItem(final int i) throws Exception { final SyndEntry entry = items.get(i); assertProperty(entry.getAuthor(), "channel.item[" + i + "].author"); + testUri(entry, i); } diff --git a/rome-core/src/test/java/com/rometools/rome/unittest/issues/Issue2Test.java b/rome-core/src/test/java/com/rometools/rome/unittest/issues/Issue2Test.java index fdfea84ff..811acfe8b 100644 --- a/rome-core/src/test/java/com/rometools/rome/unittest/issues/Issue2Test.java +++ b/rome-core/src/test/java/com/rometools/rome/unittest/issues/Issue2Test.java @@ -33,7 +33,8 @@ protected void testItem(final int i) throws Exception { } protected void testComments(final SyndEntry entry, final int i) throws Exception { - assertProperty(entry.findRelatedLink("comments").getHref(), "rss_0.94.channel.item[" + i + "].comments"); + final String property = entry.findRelatedLink("comments").getHref(); + assertProperty(property, "channel.item[" + i + "].comments"); } }