Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand environment variables in --args= which contains lowercase symbols, like ${TF_VAR_lowercase} #719

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

MaxymVlasov
Copy link
Collaborator

@MaxymVlasov MaxymVlasov commented Sep 13, 2024

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Improves https://github.com/antonbabenko/pre-commit-terraform?tab=readme-ov-file#all-hooks-usage-of-environment-variables-in---args
Found in #718 (comment)

Support of this option probably will not be needed in any observed use cases, but it is cheap to implement, so here we are

@MaxymVlasov MaxymVlasov changed the title feat: Add support to --env-vars= variables which contains lowercase symbols, like TF_VAR_<lowercase> feat: Add support to --env-vars= variables which contains lowercase symbols, like TF_VAR_lowercase Sep 13, 2024
@MaxymVlasov MaxymVlasov changed the title feat: Add support to --env-vars= variables which contains lowercase symbols, like TF_VAR_lowercase feat: Expand environment variables in --args= which contains lowercase symbols, like TF_VAR_lowercase Sep 13, 2024
@MaxymVlasov MaxymVlasov changed the title feat: Expand environment variables in --args= which contains lowercase symbols, like TF_VAR_lowercase feat: Expand environment variables in --args= which contains lowercase symbols, like ${TF_VAR_lowercase} Sep 13, 2024
@MaxymVlasov MaxymVlasov merged commit bf156b4 into master Sep 16, 2024
10 checks passed
@MaxymVlasov MaxymVlasov deleted the support_tf_env_vars branch September 16, 2024 14:02
antonbabenko pushed a commit that referenced this pull request Sep 16, 2024
# [1.96.0](v1.95.0...v1.96.0) (2024-09-16)

### Features

* Expand environment variables in `--args=` which contains lowercase symbols, like `${TF_VAR_lowercase}` ([#719](#719)) ([bf156b4](bf156b4))
@antonbabenko
Copy link
Owner

This PR is included in version 1.96.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants