feat(terraform_docs): Drop support for terraform-docs <0.12.0
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yermulnik
approved these changes
Sep 10, 2024
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
antonbabenko
pushed a commit
that referenced
this pull request
Sep 11, 2024
# [1.95.0](v1.94.3...v1.95.0) (2024-09-11) ### Features * **`terraform_docs`:** Drop support for `terraform-docs` <0.12.0 ([#717](#717)) ([81e4572](81e4572))
|
This PR is included in version 1.95.0 🎉 |
ryan-at-ld
added a commit
to ryan-at-ld/pre-commit-terraform
that referenced
this pull request
Sep 16, 2024
…1.95.0 A bug in the terraform-docs hook was introduced by the code changes in antonbabenko#717. [A continue statement was added that is not preceded by a `popd` command](https://github.com/antonbabenko/pre-commit-terraform/blob/869a106a4c8c48f34f58318a830436142e31e10a/hooks/terraform_docs.sh#L216). The bug is only triggered when the hook is processing multiple files where one (or more) of the files does not contain the terraform-docs marker statements. The hook fails to process the remaining files because the working directory is not reset to the root of the repository.
4 tasks
MaxymVlasov
pushed a commit
that referenced
this pull request
Sep 17, 2024
…ut `terraform-docs` markers. Issue introduced in v1.95.0 (#720) A bug in the terraform-docs hook was introduced by the code changes in #717. [A continue statement was added that is not preceded by a `popd` command](https://github.com/antonbabenko/pre-commit-terraform/blob/869a106a4c8c48f34f58318a830436142e31e10a/hooks/terraform_docs.sh#L216). The bug is only triggered when the hook is processing multiple files where one (or more) of the files does not contain the terraform-docs marker statements. The hook fails to process the remaining files because the working directory is not reset to the root of the repository.
antonbabenko
pushed a commit
that referenced
this pull request
Sep 17, 2024
## [1.96.1](v1.96.0...v1.96.1) (2024-09-17) ### Bug Fixes * **`terraform_docs`:** Fix issue with processing multiply files without `terraform-docs` markers. Issue introduced in v1.95.0 ([#720](#720)) ([2b1aec8](2b1aec8)), closes [#717](#717) [/github.com/antonbabenko/pre-commit-terraform/blob/869a106a4c8c48f34f58318a830436142e31e10a/hooks/terraform_docs.sh#L216](https://github.com//github.com/antonbabenko/pre-commit-terraform/blob/869a106a4c8c48f34f58318a830436142e31e10a/hooks/terraform_docs.sh/issues/L216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Cleanup of old awk hacks introduced long time ago when
terraform-docswasn't able to work with terraform 0.12+.How can we test changes