Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Action: Build docker image with latest tag with all tools nightly #321

Closed
MaxymVlasov opened this issue Jan 11, 2022 · 3 comments
Closed

GH Action: Build docker image with latest tag with all tools nightly #321

MaxymVlasov opened this issue Jan 11, 2022 · 3 comments
Labels
area/docker estimate/2h Need 2 hours to be done feature New feature or request good first issue Good for newcomers
Milestone
Features implemen...

Comments

@MaxymVlasov
Copy link
Collaborator

From time to time new tools version is released, and part of our users would like to use the docker image with cutting the edge tools versions.

So let's provide the latest tag for them.
@MaxymVlasov MaxymVlasov added feature New feature or request good first issue Good for newcomers area/docker labels Jan 11, 2022
@MaxymVlasov MaxymVlasov added the estimate/2h Need 2 hours to be done label Jan 11, 2022
@mohitsaxenaknoldus
Copy link
Contributor

Aren't we already using {{ env.IMAGE_TAG }}?

@MaxymVlasov
Copy link
Collaborator Author

Yes

pre-commit-terraform/.github/workflows/build-image.yaml

Lines 25 to 27 in 71647bb

- name: Set tag for image
run: |
echo IMAGE_TAG=$([ ${{ github.ref_type }} == 'tag' ] && echo ${{ github.ref_name }} || echo 'latest') >> $GITHUB_ENV

@pasqualedevita pasqualedevita mentioned this issue Feb 13, 2022
Merged
4 tasks
@MaxymVlasov
Copy link
Collaborator Author

Closed by #343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docker estimate/2h Need 2 hours to be done feature New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Features implementing and cleanup wit...
Development

No branches or pull requests
2 participants
@MaxymVlasov @mohitsaxenaknoldus